EXPECT_EQ(String(...), decimalNumber.toString()) displays object dump. We can't understand what is expected string.
Created attachment 152911 [details] Patch 1
Comment on attachment 152911 [details] Patch 1 Could you review this patch? Thanks in advance.
Comment on attachment 152911 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=152911&action=review > Source/WebKit/chromium/tests/DecimalTest.cpp:1025 > + EXPECT_STREQ("0", Decimal::zero(Positive).toString().ascii().data()); Please add another macro like EXPECT_DECIMALSTRING(expectation, decimal) EXPECT_STREQ(expectation, decimal.toString().ascii().data())
Created attachment 152913 [details] Patch 2
Comment on attachment 152913 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Change summary to extend scope of using EXPECT_STREQ for all test cases which use EXPECT_EQ with String class. * Introduce EXPECT_DECIMAL_STREQ * Change DecimalTest::stepDown() and stepUp() for adopting EXPECT_DECIMAL_STREQ.
Comment on attachment 152913 [details] Patch 2 Looks nice.
Comment on attachment 152913 [details] Patch 2 Clearing flags on attachment: 152913 Committed r122916: <http://trac.webkit.org/changeset/122916>
All reviewed patches have been landed. Closing bug.