Add image-orientation support to WebKit. http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation The css3-images module is at candidate recommendation. I propose to introduce the property initially behind a compile flag. There is existing code that allows a setting to determine whether embedded image orientations are respected. I propose that to integrate this new feature with the existing one, that if the setting is enabled and an embedded orientation is present that the embedded orientation take precedence over any out-of-band orientation.
> I propose that to integrate this new feature with the existing one, that if the setting is enabled and an embedded orientation is present that the embedded orientation take precedence over any out-of-band orientation. It's not clear to me that this is the correct behavior. css3-images dodges the issue of EXIF, but it seems that the spec implies that image-orientation would win.
From the spec: Note that some devices will "tag" an image with some metadata indicating its correct orientation, so image viewing software can do the necessary transformation themselves. Due to legacy compatibility restraints, Web browsers are required to ignore this data by default. A future level of this specification is expected to have a value that applies the metadata-specified transformation automatically. From the somewhat-relate image-resolution section: from-image: The image's intrinsic resolution is taken as that specified by the image format. If the image does not specify its own resolution, the explicitly specified resolution is used (if given), else it defaults to '1ddpx'. My interpretation: The existing setting is considered non-conformant if enabled by default. How embedded image orientation and out-of-band orientation ought to be resolved is unspecified and left for a future level of the spec. However, if the future level follows the same pattern set forth for image-resolution, it would read: from-image: The image's intrinsic orientation is taken as that specified by the image format. If the image does not specify its own orientation, the explicitly specified orientation is used (if given), else it defaults to '0deg'. With this projection, I would consider the existing setting to be equivalent to: * { image-orientation: from-image; } In that case, the following ought to ignore embedded orientation: img { image-orientation: 90deg; } So I'm inclined to agree with Simon.
I concur. If the page author has specified a rotation, that would win.
I also agree. The setting that makes images respect EXIF can be recast as a user-agent-level rule that applies "image-orientation: from-image" to all image elements. The author's explicit declarations will then automatically win.
Oh, and just to put your fear to rest, David, Images 4 (which I'll write up Any Day Now) will indeed have the "image-orientation: from-image" value, and it will work exactly like image-resolution, as you expect.
Created attachment 153729 [details] Draft patch Draft patch outlining scope of changes. Still navigating build and logical errors.
Comment on attachment 153729 [details] Draft patch View in context: https://bugs.webkit.org/attachment.cgi?id=153729&action=review > Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp:215 > + if (styleOrientation != OriginTopLeft && shouldRespectOrientation == RespectImageOrientation) Oops, the condition should be: (styleOrientation == OriginTopLeft && shouldRespectOrientation == RespectImageOrientation). The basis for this condition is that we cannot distinguish between explicit 'image-orientation: 0deg' and the initial value.
Created attachment 154275 [details] Draft patch Largely complete, need to make sure it applies cleany to all ports and possibly split into smaller patches.
Comment on attachment 154275 [details] Draft patch Attachment 154275 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13353123
Comment on attachment 154275 [details] Draft patch Attachment 154275 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13339161
Comment on attachment 154275 [details] Draft patch Attachment 154275 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13347141
Created attachment 154546 [details] Draft patch Rebased against bug 92330.
Created attachment 154550 [details] Draft patch Missed a single instance of a variable rename.
David is no longer working on Chromium -- Mike, can you reassign?
Created attachment 207077 [details] Updated patch
Assigned to me.
Comment on attachment 207077 [details] Updated patch Attachment 207077 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1105789
Comment on attachment 207077 [details] Updated patch Attachment 207077 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1098900
Comment on attachment 207077 [details] Updated patch Attachment 207077 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1099814
Comment on attachment 207077 [details] Updated patch Attachment 207077 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1132097
Comment on attachment 207077 [details] Updated patch Attachment 207077 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1106832
Comment on attachment 207077 [details] Updated patch Attachment 207077 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1103803
Comment on attachment 207077 [details] Updated patch Attachment 207077 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1095774
Comment on attachment 207077 [details] Updated patch Attachment 207077 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1131178
Created attachment 209324 [details] Patch for ews
Comment on attachment 209324 [details] Patch for ews Attachment 209324 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1523613
Comment on attachment 209324 [details] Patch for ews Attachment 209324 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1532048
Comment on attachment 209324 [details] Patch for ews Attachment 209324 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1494354
Comment on attachment 209324 [details] Patch for ews Attachment 209324 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1524053
Created attachment 209328 [details] Patch for ews
Created attachment 209360 [details] Patch for ews
Comment on attachment 209360 [details] Patch for ews Attachment 209360 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1538090
Comment on attachment 209360 [details] Patch for ews Attachment 209360 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1380553
Comment on attachment 209360 [details] Patch for ews Attachment 209360 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1488096
Comment on attachment 209360 [details] Patch for ews Attachment 209360 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1536098
Comment on attachment 209360 [details] Patch for ews Attachment 209360 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1393148
Created attachment 209624 [details] Patch for ews
Created attachment 209628 [details] Patch
Comment on attachment 209628 [details] Patch Attachment 209628 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1574003 New failing tests: fast/canvas/webgl/premultiplyalpha-test.html fast/canvas/pattern-with-transform.html fast/canvas/canvas-pattern-modify.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html fast/canvas/webgl/tex-sub-image-2d-bad-args.html canvas/philip/tests/initial.reset.pattern.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html canvas/philip/tests/2d.pattern.modify.canvas2.html fast/canvas/webgl/texture-active-bind.html fast/canvas/webgl/tex-image-webgl.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html fast/canvas/webgl/texture-npot.html fast/canvas/webgl/canvas-2d-webgl-texture.html canvas/philip/tests/2d.pattern.paint.orientation.canvas.html fast/canvas/canvas-pattern-behaviour.html canvas/philip/tests/2d.pattern.modify.canvas1.html canvas/philip/tests/2d.pattern.basic.canvas.html http/tests/inspector/inspect-element.html
Created attachment 209633 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 209628 [details] Patch Need to fix some tests as well as exif-orientation tests on mac port.
Created attachment 209941 [details] Patch for mac port regression
Comment on attachment 209941 [details] Patch for mac port regression Attachment 209941 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1624444
Comment on attachment 209941 [details] Patch for mac port regression Attachment 209941 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1627425 New failing tests: fast/images/exif-orientation-image-document.html fast/images/exif-orientation.html fast/images/exif-orientation-composited.html
Created attachment 209948 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 209941 [details] Patch for mac port regression Attachment 209941 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1635045 New failing tests: fast/images/exif-orientation-image-document.html fast/images/exif-orientation.html fast/images/exif-orientation-composited.html
Created attachment 209949 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Comment on attachment 209941 [details] Patch for mac port regression Attachment 209941 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1591772 New failing tests: fast/images/exif-orientation-image-document.html fast/images/exif-orientation.html fast/images/exif-orientation-composited.html
Created attachment 209950 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Created attachment 209972 [details] Patch
Comment on attachment 209972 [details] Patch Attachment 209972 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1618629 New failing tests: http/tests/security/canvas-cors-with-two-hosts.html fast/canvas/canvas-blending-image-over-gradient.html http/tests/security/canvas-remote-read-data-url-image.html fast/canvas/DrawImageSinglePixelStretch.html fast/images/paint-subrect-grid.html fast/canvas/canvas-blending-gradient-over-image.html http/tests/inspector/inspect-element.html fast/canvas/canvas-blending-image-over-image.html canvas/philip/tests/toDataURL.png.complexcolours.html fast/images/paint-subrect.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html canvas/philip/tests/toDataURL.jpeg.quality.basic.html fast/canvas/canvas-blending-color-over-image.html fast/dom/image-object.html http/tests/canvas/webgl/origin-clean-conformance.html canvas/philip/tests/toDataURL.jpeg.primarycolours.html http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html fast/canvas/canvas-blending-pattern-over-image.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html canvas/philip/tests/toDataURL.png.primarycolours.html fast/canvas/canvas-blending-image-over-pattern.html canvas/philip/tests/security.dataURI.html fast/images/cmyk-jpeg-with-color-profile.html fast/canvas/canvas-incremental-repaint.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html fast/canvas/canvas-scale-drawImage-shadow.html fast/canvas/canvas-blending-image-over-color.html canvas/philip/tests/toDataURL.jpeg.alpha.html fast/canvas/canvas-drawImage-shadow.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html
Created attachment 209985 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Comment on attachment 209972 [details] Patch Attachment 209972 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1644081 New failing tests: http/tests/security/canvas-cors-with-two-hosts.html fast/canvas/canvas-blending-image-over-gradient.html http/tests/security/canvas-remote-read-data-url-image.html fast/canvas/DrawImageSinglePixelStretch.html fast/images/paint-subrect-grid.html fast/canvas/canvas-blending-gradient-over-image.html http/tests/inspector/inspect-element.html fast/canvas/canvas-blending-image-over-image.html canvas/philip/tests/toDataURL.png.complexcolours.html fast/images/paint-subrect.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html canvas/philip/tests/toDataURL.jpeg.quality.basic.html fast/canvas/canvas-blending-color-over-image.html fast/dom/image-object.html http/tests/canvas/webgl/origin-clean-conformance.html canvas/philip/tests/toDataURL.jpeg.primarycolours.html http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html fast/canvas/canvas-blending-pattern-over-image.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html fast/canvas/canvas-blending-image-over-pattern.html platform/mac/fast/canvas/canvas-draw-xbm-image.html canvas/philip/tests/security.dataURI.html fast/images/cmyk-jpeg-with-color-profile.html platform/mac/editing/deleting/deletionUI-single-instance.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html fast/canvas/canvas-blending-image-over-color.html canvas/philip/tests/toDataURL.jpeg.alpha.html canvas/philip/tests/toDataURL.png.primarycolours.html fast/replaced/width-and-height-of-positioned-replaced-elements.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html
Created attachment 210038 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Created attachment 210224 [details] Patch
Comment on attachment 210224 [details] Patch Attachment 210224 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1657496
Comment on attachment 210224 [details] Patch Attachment 210224 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1658539
Comment on attachment 210224 [details] Patch Attachment 210224 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1661540
Comment on attachment 210224 [details] Patch Attachment 210224 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1680059
Comment on attachment 210224 [details] Patch Attachment 210224 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1603511
Comment on attachment 210224 [details] Patch Attachment 210224 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1659500
Created attachment 210257 [details] Patch
Created attachment 210262 [details] Patch
CC'ing Beth.
Created attachment 211496 [details] Rebased patch
Comment on attachment 211496 [details] Rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=211496&action=review LGTM > Source/WebCore/loader/cache/CachedImage.cpp:260 > + ImageOrientationDescription orientationDescirption(renderer->shouldRespectImageOrientation()); nit orientationDescription
Created attachment 211527 [details] Patch
(In reply to comment #66) > (From update of attachment 211496 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211496&action=review > > LGTM > > > Source/WebCore/loader/cache/CachedImage.cpp:260 > > + ImageOrientationDescription orientationDescirption(renderer->shouldRespectImageOrientation()); > > nit orientationDescription Thank you for your review. Fixed it.
Comment on attachment 211527 [details] Patch Attachment 211527 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1884153
Created attachment 211530 [details] Patch
Beth or others, could anyone review this patch ? I really want to land this patch.
Comment on attachment 211530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211530&action=review > Source/WebCore/loader/cache/CachedImage.cpp:261 > + if (renderer && renderer->style()) It doesn't make any sense to null-check renderer here. If it is ever null, then you will crash on the previous line since you access it without a null check there. Figure out if it can ever be null, and if so, null-check it before you use it at all. If it cannot be null, then don't null check it. > Source/WebCore/page/DragController.cpp:889 > + if (element->renderer() && element->renderer()->style()) Same comment about null-checking applies here. > Source/WebCore/page/Frame.cpp:1040 > + if (renderer->style()) Is it necessary to null-check style? > Source/WebCore/platform/graphics/Image.h:-206 > - virtual void draw(GraphicsContext*, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace styleColorSpace, CompositeOperator, BlendMode) = 0; Why is this function being removed? > Source/WebCore/rendering/RenderImage.cpp:150 > + if (diff == StyleDifferenceLayout There's no reason to break this if-condition onto two lines. > LayoutTests/fast/css/image-orientation/image-orientation.html:8 > +description('Apply image-orientation property and check computed style.'); You should add an explanation to the LayoutTest change log to explain your changes to this test. Was this description always inaccurate and you are just correcting it? Please explain.
Comment on attachment 211530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211530&action=review Beth, Thank you for your review :) >> Source/WebCore/loader/cache/CachedImage.cpp:261 >> + if (renderer && renderer->style()) > > It doesn't make any sense to null-check renderer here. If it is ever null, then you will crash on the previous line since you access it without a null check there. Figure out if it can ever be null, and if so, null-check it before you use it at all. If it cannot be null, then don't null check it. It looks we need to check if *renderer* is null. However, we don't need to check if style() is null. Renderer should have a style. >> Source/WebCore/platform/graphics/Image.h:-206 >> - virtual void draw(GraphicsContext*, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace styleColorSpace, CompositeOperator, BlendMode) = 0; > > Why is this function being removed? I thought that we don't need to keep this function anymore, because all child classes derived from Image class should implement this draw() which doesn't have *ImageOrientationDescription* argument additionally. But, I think now I don't have a clear reason to remove this function. So, I keep this function in next patch. >> Source/WebCore/rendering/RenderImage.cpp:150 >> + if (diff == StyleDifferenceLayout > > There's no reason to break this if-condition onto two lines. Done. >> LayoutTests/fast/css/image-orientation/image-orientation.html:8 >> +description('Apply image-orientation property and check computed style.'); > > You should add an explanation to the LayoutTest change log to explain your changes to this test. Was this description always inaccurate and you are just correcting it? Please explain. This line has wrong description for this test. This test is for testing image orientation, not image resolution. Fixed it. > LayoutTests/fast/css/image-orientation/image-orientation.html:22 > + shouldBe('p.style.cssText', '"image-orientation: ' + test + ';"'); I think this test doesn't need to add a space at the end of line.
Created attachment 212048 [details] Patch according to Beth's comments
Created attachment 212070 [details] Patch according to Beth's comments
Comment on attachment 212070 [details] Patch according to Beth's comments Attachment 212070 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1968201 New failing tests: http/tests/security/canvas-cors-with-two-hosts.html fast/canvas/canvas-blending-image-over-pattern.html fast/canvas/canvas-blending-image-over-gradient.html http/tests/security/canvas-remote-read-data-url-image.html webgl/conformance/extensions/oes-texture-float-with-image.html fast/canvas/drawImage-with-invalid-args.html fast/canvas/canvas-blending-gradient-over-image.html fast/canvas/canvas-blending-image-over-image.html canvas/philip/tests/toDataURL.png.complexcolours.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html canvas/philip/tests/toDataURL.jpeg.quality.basic.html fast/canvas/canvas-blending-color-over-image.html fast/dom/image-object.html http/tests/canvas/webgl/origin-clean-conformance.html canvas/philip/tests/toDataURL.jpeg.primarycolours.html http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html fast/canvas/canvas-blending-pattern-over-image.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html canvas/philip/tests/toDataURL.png.primarycolours.html svg/as-image/svg-canvas-xhtml-tainted.html canvas/philip/tests/security.dataURI.html svg/as-image/svg-canvas-link-not-colored.html fast/images/cmyk-jpeg-with-color-profile.html fast/canvas/canvas-incremental-repaint.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html fast/canvas/canvas-scale-drawImage-shadow.html fast/canvas/canvas-blending-image-over-color.html canvas/philip/tests/toDataURL.jpeg.alpha.html fast/canvas/canvas-drawImage-shadow.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html
Created attachment 212077 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 212070 [details] Patch according to Beth's comments Attachment 212070 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1999131 New failing tests: http/tests/security/canvas-cors-with-two-hosts.html webgl/conformance/canvas/to-data-url-test.html fast/canvas/canvas-blending-image-over-pattern.html fast/canvas/canvas-blending-image-over-gradient.html http/tests/security/canvas-remote-read-data-url-image.html webgl/conformance/extensions/oes-texture-float-with-image.html fast/canvas/drawImage-with-invalid-args.html fast/canvas/canvas-blending-gradient-over-image.html fast/canvas/canvas-blending-image-over-image.html canvas/philip/tests/toDataURL.png.complexcolours.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html canvas/philip/tests/toDataURL.jpeg.quality.basic.html fast/canvas/canvas-blending-color-over-image.html fast/dom/image-object.html http/tests/canvas/webgl/origin-clean-conformance.html canvas/philip/tests/toDataURL.jpeg.primarycolours.html fast/canvas/canvas-blending-pattern-over-image.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html canvas/philip/tests/toDataURL.png.primarycolours.html svg/as-image/svg-canvas-xhtml-tainted.html canvas/philip/tests/security.dataURI.html svg/as-image/svg-canvas-link-not-colored.html fast/images/cmyk-jpeg-with-color-profile.html fast/canvas/canvas-incremental-repaint.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html fast/canvas/canvas-scale-drawImage-shadow.html fast/canvas/canvas-blending-image-over-color.html canvas/philip/tests/toDataURL.jpeg.alpha.html fast/canvas/canvas-drawImage-shadow.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html
Created attachment 212089 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 212254 [details] Patch
Comment on attachment 212254 [details] Patch Attachment 212254 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1883503
Comment on attachment 212254 [details] Patch Attachment 212254 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1929206 New failing tests: http/tests/local/drag-over-remote-content.html editing/pasteboard/4947130.html platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html editing/pasteboard/drag-image-to-contenteditable-in-iframe.html http/tests/security/drag-over-remote-content-iframe.html editing/pasteboard/drag-and-drop-image-contenteditable.html editing/pasteboard/drag-selected-image-to-contenteditable.html editing/pasteboard/files-during-page-drags.html editing/selection/drag-to-contenteditable-iframe.html editing/pasteboard/drag-image-in-about-blank-frame.html fast/events/standalone-image-drag-to-editable.html http/tests/security/drag-drop-same-unique-origin.html http/tests/misc/bubble-drag-events.html
Created attachment 212259 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 212254 [details] Patch Attachment 212254 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2029090 New failing tests: http/tests/local/drag-over-remote-content.html editing/pasteboard/4947130.html platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html editing/pasteboard/drag-image-to-contenteditable-in-iframe.html http/tests/security/drag-over-remote-content-iframe.html editing/pasteboard/drag-and-drop-image-contenteditable.html editing/pasteboard/drag-selected-image-to-contenteditable.html editing/pasteboard/files-during-page-drags.html editing/selection/drag-to-contenteditable-iframe.html editing/pasteboard/drag-image-in-about-blank-frame.html fast/events/standalone-image-drag-to-editable.html http/tests/security/drag-drop-same-unique-origin.html http/tests/misc/bubble-drag-events.html
Created attachment 212267 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 213510 [details] Patch
Comment on attachment 213510 [details] Patch Attachment 213510 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3493106 New failing tests: http/tests/local/drag-over-remote-content.html editing/pasteboard/4947130.html platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html editing/pasteboard/drag-image-to-contenteditable-in-iframe.html http/tests/security/drag-over-remote-content-iframe.html editing/pasteboard/drag-and-drop-image-contenteditable.html editing/pasteboard/drag-selected-image-to-contenteditable.html editing/pasteboard/files-during-page-drags.html editing/selection/drag-to-contenteditable-iframe.html editing/pasteboard/drag-image-in-about-blank-frame.html fast/events/standalone-image-drag-to-editable.html http/tests/security/drag-drop-same-unique-origin.html http/tests/misc/bubble-drag-events.html
Created attachment 213532 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 213510 [details] Patch Attachment 213510 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3560013 New failing tests: http/tests/local/drag-over-remote-content.html editing/pasteboard/4947130.html platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html editing/pasteboard/drag-image-to-contenteditable-in-iframe.html http/tests/security/drag-over-remote-content-iframe.html editing/pasteboard/drag-and-drop-image-contenteditable.html editing/pasteboard/drag-selected-image-to-contenteditable.html editing/pasteboard/files-during-page-drags.html editing/selection/drag-to-contenteditable-iframe.html editing/pasteboard/drag-image-in-about-blank-frame.html fast/events/standalone-image-drag-to-editable.html http/tests/security/drag-drop-same-unique-origin.html http/tests/misc/bubble-drag-events.html
Created attachment 213537 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 213510 [details] Patch Attachment 213510 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3573003 New failing tests: http/tests/local/drag-over-remote-content.html editing/pasteboard/4947130.html platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html editing/pasteboard/drag-image-to-contenteditable-in-iframe.html http/tests/security/drag-over-remote-content-iframe.html editing/pasteboard/drag-and-drop-image-contenteditable.html editing/pasteboard/drag-selected-image-to-contenteditable.html editing/pasteboard/files-during-page-drags.html editing/selection/drag-to-contenteditable-iframe.html editing/pasteboard/drag-image-in-about-blank-frame.html fast/events/standalone-image-drag-to-editable.html http/tests/security/drag-drop-same-unique-origin.html http/tests/misc/bubble-drag-events.html
Created attachment 213543 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 213510 [details] Patch Attachment 213510 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3493122
Created attachment 214355 [details] Patch
Comment on attachment 214355 [details] Patch Attachment 214355 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/4111259
Created attachment 214408 [details] Patch
Comment on attachment 214408 [details] Patch Attachment 214408 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3494625
Created attachment 214413 [details] Patch
(In reply to comment #72) > > Source/WebCore/platform/graphics/Image.h:-206 > > - virtual void draw(GraphicsContext*, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace styleColorSpace, CompositeOperator, BlendMode) = 0; > > Why is this function being removed? Hi Beth, first of all, sorry for too late update. I fixed other stuffs according to your comments except for this draw() removal. In my humble opinion, this draw() has just called other draw() with an imageOrientationDescription argument. So, I don't think we don't need to keep it anymore. For instance, please look at below function. void BitmapImage::draw(GraphicsContext* ctx, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace styleColorSpace, CompositeOperator op, BlendMode blendMode) { draw(ctx, dstRect, srcRect, styleColorSpace, op, blendMode, ImageOrientationDescription()); }
Comment on attachment 214413 [details] Patch Clearing flags on attachment: 214413 Committed r157909: <http://trac.webkit.org/changeset/157909>
All reviewed patches have been landed. Closing bug.
30 regressions occur after landing this patch on GTK port only. Let me fix it. Please do not revert this patch.