Bug 91551 - Fix a bug where optimize-baselines would incorrectly fail to optimize
Summary: Fix a bug where optimize-baselines would incorrectly fail to optimize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-17 15:51 PDT by Tony Chang
Modified: 2012-07-17 17:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (7.62 KB, patch)
2012-07-17 15:55 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-07-17 15:51:50 PDT
Fix a bug where optimize-baselines would incorrectly fail to optimize
Comment 1 Tony Chang 2012-07-17 15:55:40 PDT
Created attachment 152858 [details]
Patch
Comment 2 Dirk Pranke 2012-07-17 16:02:05 PDT
Comment on attachment 152858 [details]
Patch

bah ... this optimizer code is all black magic to me :(, although I at least understand the testcase. Adam, what do you think?
Comment 3 Adam Barth 2012-07-17 16:20:27 PDT
Comment on attachment 152858 [details]
Patch

ok
Comment 4 Adam Barth 2012-07-17 16:21:00 PDT
I suspect the optimizer could be made much simpler now that the fallback graph is more tree-like.
Comment 5 Ojan Vafai 2012-07-17 16:32:18 PDT
(In reply to comment #4)
> I suspect the optimizer could be made much simpler now that the fallback graph is more tree-like.

I don't think so. With wk2, the graph is still not a tree. Also, we still need to support mac-future/win-future for unreleased Apple ports. It's not clear to me what function qt-future serves though.
Comment 6 WebKit Review Bot 2012-07-17 17:26:39 PDT
Comment on attachment 152858 [details]
Patch

Clearing flags on attachment: 152858

Committed r122902: <http://trac.webkit.org/changeset/122902>
Comment 7 WebKit Review Bot 2012-07-17 17:26:43 PDT
All reviewed patches have been landed.  Closing bug.