RESOLVED FIXED Bug 91551
Fix a bug where optimize-baselines would incorrectly fail to optimize 
https://bugs.webkit.org/show_bug.cgi?id=91551
Summary Fix a bug where optimize-baselines would incorrectly fail to optimize
Tony Chang
Reported 2012-07-17 15:51:50 PDT
Fix a bug where optimize-baselines would incorrectly fail to optimize
Attachments
Patch (7.62 KB, patch)
2012-07-17 15:55 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-07-17 15:55:40 PDT
Created attachment 152858 [details] Patch
Dirk Pranke
Comment 2 2012-07-17 16:02:05 PDT
Comment on attachment 152858 [details] Patch bah ... this optimizer code is all black magic to me :(, although I at least understand the testcase. Adam, what do you think?
Adam Barth
Comment 3 2012-07-17 16:20:27 PDT
Comment on attachment 152858 [details] Patch ok
Adam Barth
Comment 4 2012-07-17 16:21:00 PDT
I suspect the optimizer could be made much simpler now that the fallback graph is more tree-like.
Ojan Vafai
Comment 5 2012-07-17 16:32:18 PDT
(In reply to comment #4) > I suspect the optimizer could be made much simpler now that the fallback graph is more tree-like. I don't think so. With wk2, the graph is still not a tree. Also, we still need to support mac-future/win-future for unreleased Apple ports. It's not clear to me what function qt-future serves though.
WebKit Review Bot
Comment 6 2012-07-17 17:26:39 PDT
Comment on attachment 152858 [details] Patch Clearing flags on attachment: 152858 Committed r122902: <http://trac.webkit.org/changeset/122902>
WebKit Review Bot
Comment 7 2012-07-17 17:26:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.