Bug 91550 - [Chromium] Disable printing on chromium-android
Summary: [Chromium] Disable printing on chromium-android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency treegraph
 
Reported: 2012-07-17 15:45 PDT by Adam Barth
Modified: 2012-07-18 17:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.37 KB, patch)
2012-07-17 15:46 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (2.20 KB, patch)
2012-07-18 15:01 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-07-17 15:45:41 PDT
Disable printing on chromium-android
Comment 1 Adam Barth 2012-07-17 15:46:51 PDT
Created attachment 152855 [details]
Patch
Comment 2 Peter Beverloo 2012-07-18 02:11:42 PDT
Comment on attachment 152855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152855&action=review

LGTM, thanks! I'll post a patch downstream today to clean this up, as this might cause potential merge confusion.

> Source/WebKit/chromium/ChangeLog:3
> +        Disable printing on chromium-android

nit: Despite mentioning chromium-android in the title, generally [Chromium] as a prefix is clearer.

> Source/WebKit/chromium/ChangeLog:8
> +        We don't implementing printing on Android.

nit: s/implementing/implement/
Comment 3 Adam Barth 2012-07-18 15:01:33 PDT
Created attachment 153096 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-07-18 17:07:29 PDT
Comment on attachment 153096 [details]
Patch for landing

Clearing flags on attachment: 153096

Committed r123049: <http://trac.webkit.org/changeset/123049>
Comment 5 WebKit Review Bot 2012-07-18 17:07:33 PDT
All reviewed patches have been landed.  Closing bug.