Bug 91538 - NRWT support of per-test args and pass --pixel-tests in per-test args
Summary: NRWT support of per-test args and pass --pixel-tests in per-test args
Status: RESOLVED DUPLICATE of bug 92398
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: NRWT
Depends on:
Blocks: 91539
  Show dependency tree / graph
 
Reported: 2012-07-17 13:43 PDT by Xianzhu Wang
Modified: 2012-08-06 09:05 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-07-17 13:43:01 PDT 
For now, when running NRWT with --no-pixel-tests, DriverProxy maintains two drivers one of which run non pixel tests and one run ref tests.
This causes problem of chromium-android which doesn't support multiple drivers on one device. On chromium-android we don't use DriverProxy but restart the single driver when pixel-test mode changes. Bug 91533 groups the ref tests together to reduce the cost of restarting the driver on chromium-android.

The problem would be resolved if we can let one driver/DRT support support both pixel and non-pixel tests, that is, the --pixel-tests should be passed as a per-test arg instead of a command-line parameter to DRT.
Comment 1 Balazs Kelemen 2012-08-06 07:29:50 PDT 
I believe this has been basically fixed in bug 91754 and bug 92398.
Comment 2 Xianzhu Wang 2012-08-06 09:05:02 PDT 
Thanks!

*** This bug has been marked as a duplicate of bug 92398 ***