Bug 91522 - Add MIPS add32 function
Summary: Add MIPS add32 function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-17 10:44 PDT by Chao-ying Fu
Modified: 2012-07-31 11:44 PDT (History)
1 user (show)

See Also:

Attachments
MIPS add32 function (1.37 KB, patch)
2012-07-17 10:48 PDT, Chao-ying Fu 		ap: commit-queue-
Details | Formatted Diff | Diff
Update ChangeLog to include descriptions (1.36 KB, patch)
2012-07-18 13:36 PDT, Chao-ying Fu 		no flags Details | Formatted Diff | Diff
Add MIPS isCompactPtrAlignedAddressOffset and add32 (1.77 KB, patch)
2012-07-25 16:04 PDT, Chao-ying Fu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chao-ying Fu 2012-07-17 10:44:21 PDT 
Hi, I will post a patch to add "add32" function.  Thanks!
Comment 1 Chao-ying Fu 2012-07-17 10:48:56 PDT 
Created attachment 152785 [details]
MIPS add32 function

Here is the patch.  The jsc testing is ok.  Thanks!
Comment 2 Alexey Proskuryakov 2012-07-18 12:08:14 PDT 
Comment on attachment 152785 [details]
MIPS add32 function

View in context: https://bugs.webkit.org/attachment.cgi?id=152785&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Please write a brief description, as requested here.
Comment 3 Chao-ying Fu 2012-07-18 13:36:12 PDT 
Created attachment 153078 [details]
Update ChangeLog to include descriptions

Hi, I updated ChangeLog to include descriptions.  Thanks!
Comment 4 Chao-ying Fu 2012-07-25 16:04:14 PDT 
Created attachment 154470 [details]
Add MIPS isCompactPtrAlignedAddressOffset and add32

I added the "isCompactPtrAlignedAddressOffset" function to fix the MIPS build.  The JSC testing is OK.  Thanks a lot!
Comment 5 WebKit Review Bot 2012-07-31 11:44:21 PDT 
Comment on attachment 154470 [details]
Add MIPS isCompactPtrAlignedAddressOffset and add32

Clearing flags on attachment: 154470

Committed r124228: <http://trac.webkit.org/changeset/124228>
Comment 6 WebKit Review Bot 2012-07-31 11:44:24 PDT 
All reviewed patches have been landed.  Closing bug.