Bug 91519 - Web Inspector: remove search replace from behind experiment, polish the behavior
Summary: Web Inspector: remove search replace from behind experiment, polish the behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-17 10:38 PDT by Pavel Feldman
Modified: 2012-07-18 06:41 PDT (History)
10 users (show)

See Also:


Attachments
Patch (14.94 KB, patch)
2012-07-17 14:19 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[IMAGE] Screenshot with patch applied. (18.53 KB, image/png)
2012-07-18 00:30 PDT, Pavel Feldman
no flags Details
Patch (43.22 KB, patch)
2012-07-18 00:33 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (41.50 KB, patch)
2012-07-18 03:54 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (43.71 KB, patch)
2012-07-18 05:59 PDT, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-07-17 10:38:28 PDT
This change removes search / replace from behind experiment flag
Makes replace actions undoable
Fixes incremental replace with the superstring
Comment 1 Pavel Feldman 2012-07-17 14:19:55 PDT
Created attachment 152828 [details]
Patch
Comment 2 Pavel Feldman 2012-07-18 00:30:55 PDT
Created attachment 152952 [details]
[IMAGE] Screenshot with patch applied.
Comment 3 Pavel Feldman 2012-07-18 00:33:34 PDT
Created attachment 152953 [details]
Patch
Comment 4 Pavel Feldman 2012-07-18 03:54:22 PDT
Created attachment 152981 [details]
Patch
Comment 5 Pavel Feldman 2012-07-18 05:59:33 PDT
Created attachment 153000 [details]
Patch
Comment 6 Vsevolod Vlasov 2012-07-18 06:36:30 PDT
Comment on attachment 153000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153000&action=review

> Source/WebCore/English.lproj/localizedStrings.js:726
> +localizedStrings["Replace & Find"] = "Replace & Find";

Please update properly.

> Source/WebCore/inspector/front-end/SearchController.js:202
> +        this._findButtonElement.disabled = !enabled;

Let's always enable this button.
Comment 7 Pavel Feldman 2012-07-18 06:41:22 PDT
Committed r122962: <http://trac.webkit.org/changeset/122962>