RESOLVED FIXED 91519
Web Inspector: remove search replace from behind experiment, polish the behavior 
https://bugs.webkit.org/show_bug.cgi?id=91519
Summary Web Inspector: remove search replace from behind experiment, polish the behavior
Pavel Feldman
Reported 2012-07-17 10:38:28 PDT
This change removes search / replace from behind experiment flag Makes replace actions undoable Fixes incremental replace with the superstring
Attachments
Patch (14.94 KB, patch)
2012-07-17 14:19 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[IMAGE] Screenshot with patch applied. (18.53 KB, image/png)
2012-07-18 00:30 PDT, Pavel Feldman 		no flags
Details
Patch (43.22 KB, patch)
2012-07-18 00:33 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (41.50 KB, patch)
2012-07-18 03:54 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (43.71 KB, patch)
2012-07-18 05:59 PDT, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-07-17 14:19:55 PDT
Created attachment 152828 [details] Patch
Pavel Feldman
Comment 2 2012-07-18 00:30:55 PDT
Created attachment 152952 [details] [IMAGE] Screenshot with patch applied.
Pavel Feldman
Comment 3 2012-07-18 00:33:34 PDT
Created attachment 152953 [details] Patch
Pavel Feldman
Comment 4 2012-07-18 03:54:22 PDT
Created attachment 152981 [details] Patch
Pavel Feldman
Comment 5 2012-07-18 05:59:33 PDT
Created attachment 153000 [details] Patch
Vsevolod Vlasov
Comment 6 2012-07-18 06:36:30 PDT
Comment on attachment 153000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153000&action=review > Source/WebCore/English.lproj/localizedStrings.js:726 > +localizedStrings["Replace & Find"] = "Replace & Find"; Please update properly. > Source/WebCore/inspector/front-end/SearchController.js:202 > + this._findButtonElement.disabled = !enabled; Let's always enable this button.
Pavel Feldman
Comment 7 2012-07-18 06:41:22 PDT
Committed r122962: <http://trac.webkit.org/changeset/122962>
Note You need to log in before you can comment on or make changes to this bug.