Bug 91514 – [Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Balazs Kelemen]

The test harnesses analyze the webcore lib with nm to find out what is enabled and what is not. With force_static_libs_as_shared the libQtWebKit.so actually not contains much, we need to do it better.

[Balazs Kelemen]

Created attachment 152780 [details]
Patch

[Dirk Pranke]

Comment on attachment 152780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152780&action=review

mostly looks fine ... one question:

> Tools/Scripts/webkitdirs.pm:743
> +        if ($isSearchingForWebCore) {

isn't $isSearchingForWebCore only true if WebCore is in the name? If so, does your s/// actually do anything?

[Balazs Kelemen]

(In reply to comment #2)
> (From update of attachment 152780 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=152780&action=review
> 
> mostly looks fine ... one question:
> 
> > Tools/Scripts/webkitdirs.pm:743
> > +        if ($isSearchingForWebCore) {
> 
> isn't $isSearchingForWebCore only true if WebCore is in the name? If so, does your s/// actually do anything?

Yes, because at the very first we overwrite the parameter:
if (isQt()) {
    $libraryName = "QtWebKit";
because normally libQtWebKit contains every symbol (and it seems like only features.pm use this function anyway). I know it's not really correct, but I have to keep this hacked logic to make it work with a default build and also with force_static_libs_as_shared.

[Balazs Kelemen]

Forgot to mention the motivation of fixing this: I could not run some tests without the patch. For example compositing tets are skipped, because the test harness believes AC is disabled.

[Dirk Pranke]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 152780 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=152780&action=review
> > 
> > mostly looks fine ... one question:
> > 
> > > Tools/Scripts/webkitdirs.pm:743
> > > +        if ($isSearchingForWebCore) {
> > 
> > isn't $isSearchingForWebCore only true if WebCore is in the name? If so, does your s/// actually do anything?
> 
> Yes, because at the very first we overwrite the parameter:
> if (isQt()) {
>     $libraryName = "QtWebKit";
> because normally libQtWebKit contains every symbol (and it seems like only features.pm use this function anyway). I know it's not really correct, but I have to keep this hacked logic to make it work with a default build and also with force_static_libs_as_shared.

Oh, right. Okay.

[Balazs Kelemen]

Comment on attachment 152780 [details]
Patch

Clearing flags on attachment: 152780

Committed r123021: <http://trac.webkit.org/changeset/123021>

[Balazs Kelemen]

All reviewed patches have been landed.  Closing bug.