WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
91513
Web Inspector: create timeline detail records lazily
https://bugs.webkit.org/show_bug.cgi?id=91513
Summary
Web Inspector: create timeline detail records lazily
Andrey Kosyakov
Reported
2012-07-17 10:06:51 PDT
Timeline record details include linkified locations, which are rather large. I'm getting a reduction from 132M to 117M in heap sizes by not creating record details until these are used.
Attachments
Patch
(1.62 KB, patch)
2012-07-17 10:07 PDT
,
Andrey Kosyakov
pfeldman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1
2012-07-17 10:07:59 PDT
Created
attachment 152775
[details]
Patch
Pavel Feldman
Comment 2
2012-07-17 13:11:00 PDT
Comment on
attachment 152775
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=152775&action=review
> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:633 > + get details()
Please annotate. Also, please use functions where possible since they are more compiler-friendly.
Andrey Kosyakov
Comment 3
2012-07-18 05:39:08 PDT
Committed
r122950
: <
http://trac.webkit.org/changeset/122950
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug