Bug 91513 - Web Inspector: create timeline detail records lazily
Summary: Web Inspector: create timeline detail records lazily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-17 10:06 PDT by Andrey Kosyakov
Modified: 2012-07-18 05:39 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2012-07-17 10:07 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-07-17 10:06:51 PDT 
Timeline record details include linkified locations, which are rather large. I'm getting a reduction from 132M to 117M in heap sizes by not creating record details until these are used.
Comment 1 Andrey Kosyakov 2012-07-17 10:07:59 PDT 
Created attachment 152775 [details]
Patch
Comment 2 Pavel Feldman 2012-07-17 13:11:00 PDT 
Comment on attachment 152775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152775&action=review

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:633
> +    get details()

Please annotate. Also, please use functions where possible since they are more compiler-friendly.
Comment 3 Andrey Kosyakov 2012-07-18 05:39:08 PDT 
Committed r122950: <http://trac.webkit.org/changeset/122950>