[Mac] Make WebDataSourcePrivate lighter

[Benjamin Poulain]

Improving WebPreferencesPrivate initialization had a nice outcome.
Should WebDataSourcePrivate follow the same path?

[Benjamin Poulain]

Created attachment 152778 [details]
Patch

[Benjamin Poulain]

Created attachment 152853 [details]
Patch

[Build Bot]

Comment on attachment 152853 [details]
Patch

Attachment 152853 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13280277

[Benjamin Poulain]

Created attachment 152871 [details]
Patch

[Build Bot]

Comment on attachment 152871 [details]
Patch

Attachment 152871 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13282294

[Benjamin Poulain]

Created attachment 152899 [details]
Patch

[Benjamin Poulain]

Comment on attachment 152899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152899&action=review

> Source/WebKit/mac/WebView/WebDataSource.mm:129
> +    JSC::initializeThreading();
> +    WTF::initializeMainThreadToProcessMainThread();
> +    WebCore::RunLoop::initializeMainRunLoop();
> +    WebCoreObjCFinalizeOnMainThread(self);

Joe:

if (self != [XXX class])
    return;

[Anders Carlsson]

Comment on attachment 152899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152899&action=review

> Source/WebKit/mac/WebView/WebDataSource.h:40
> +typedef struct WebDataSourcePrivate WebDataSourcePrivate;

I think other classes (in other frameworks) just use void * for internal classes. I like that better.

> Source/WebKit/mac/WebView/WebDataSource.mm:70
> +struct WebDataSourcePrivate

And then you could make this a proper class which is nicer :)

[Benjamin Poulain]

Created attachment 153139 [details]
Patch

[Anders Carlsson]

Comment on attachment 153139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153139&action=review

> Source/WebKit/mac/WebView/WebDataSource.mm:93
> +static inline WebDataSourcePrivate* castPrivate(void* privateAttribute)
>  {

We usually call these cast functions "toFoo" so toPrivate(void* ptr) would be better here.

[Benjamin Poulain]

Committed r123057: <http://trac.webkit.org/changeset/123057>

[Benjamin Poulain]

<rdar://problem/11909640>

[Joseph Pecoraro]

Comment on attachment 153139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153139&action=review

> Source/WebKit/mac/WebView/WebDataSource.mm:77
> +    WebDataSourcePrivate(PassRefPtr<WebDocumentLoaderMac> loader)
> +        : loader(loader)
> +    {
> +        ASSERT(this->loader);
> +    }

Looks like this missed initializing the BOOL members.