Bug 91499 - double data type shoud be changed to float in ColorMatrix
Summary: double data type shoud be changed to float in ColorMatrix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-17 06:18 PDT by Tamas Czene
Modified: 2012-07-20 23:07 PDT (History)
5 users (show)

See Also:

Attachments
proposed patch (5.48 KB, patch)
2012-07-17 06:24 PDT, Tamas Czene 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Czene 2012-07-17 06:18:40 PDT 
According to tests double type is unnecessary. SVG Filters use float type everywhere so we shoud change double to float.
Comment 1 Tamas Czene 2012-07-17 06:24:03 PDT 
Created attachment 152751 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2012-07-18 12:27:43 PDT 
What is the expected benefit of this change? Is it matching other code, or something else?
Comment 3 Tamas Czene 2012-07-19 01:31:41 PDT 
Opengl ES 2.0, ARM NEON, OpenCL don't support double type.
Comment 4 Alexey Proskuryakov 2012-07-19 08:52:29 PDT 
Please elaborate. This patch changes C++ code, not OpenGL or OpenCL.
Comment 5 Tamas Czene 2012-07-20 07:01:36 PDT 
For this filter doesn't need double precision and it confused me when I implemented the opencl/gl version.
The goal is to uniform the codes.
Comment 6 Alexey Proskuryakov 2012-07-20 09:21:38 PDT 
Thank you for the explanation. I'll leave final review to someone better familiar with this code, and with performance characteristics of double vs. float on modern processors.
Comment 7 Nikolas Zimmermann 2012-07-20 22:50:28 PDT 
Comment on attachment 152751 [details]
proposed patch

Looks okay to me - all tests still pass, so we're not affected by precision issues, so rs=me.
Comment 8 WebKit Review Bot 2012-07-20 23:07:34 PDT 
Comment on attachment 152751 [details]
proposed patch

Clearing flags on attachment: 152751

Committed r123288: <http://trac.webkit.org/changeset/123288>
Comment 9 WebKit Review Bot 2012-07-20 23:07:39 PDT 
All reviewed patches have been landed.  Closing bug.