Bug 91471 - Internals: Remove injectPagePopupController()
Summary: Internals: Remove injectPagePopupController()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-16 23:27 PDT by Kent Tamura
Modified: 2012-07-17 01:22 PDT (History)
2 users (show)

See Also:


Attachments
Patch (10.59 KB, patch)
2012-07-16 23:36 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch 2 (10.74 KB, patch)
2012-07-16 23:59 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-07-16 23:27:03 PDT
http://trac.webkit.org/changeset/122558 introduced injectPagePopupController(), however we'd like to avoid adding such JavaScript binding code.
https://bugs.webkit.org/show_bug.cgi?id=84827#c23
Comment 1 Kent Tamura 2012-07-16 23:36:03 PDT
Created attachment 152703 [details]
Patch
Comment 2 Build Bot 2012-07-16 23:50:57 PDT
Comment on attachment 152703 [details]
Patch

Attachment 152703 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13275063
Comment 3 Kent Tamura 2012-07-16 23:59:15 PDT
Created attachment 152704 [details]
Patch 2

Mac build fix
Comment 4 Hajime Morrita 2012-07-17 00:17:27 PDT
Comment on attachment 152704 [details]
Patch 2

Thanks for taking this.
Comment 5 WebKit Review Bot 2012-07-17 01:22:29 PDT
Comment on attachment 152704 [details]
Patch 2

Clearing flags on attachment: 152704

Committed r122823: <http://trac.webkit.org/changeset/122823>
Comment 6 WebKit Review Bot 2012-07-17 01:22:33 PDT
All reviewed patches have been landed.  Closing bug.