Bug 91470 - [EFL] Replace 0 by NULL in public headers documentation
Summary: [EFL] Replace 0 by NULL in public headers documentation
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Reported: 2012-07-16 22:40 PDT by Chris Dumez
Modified: 2012-07-17 16:13 PDT (History)
12 users (show)

See Also:

Patch (42.07 KB, patch)
2012-07-17 00:39 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-16 22:40:06 PDT
It was discussed on the mailing list that NULL was more appropriate than 0 in public WebKit-EFL and WebKit2-EFL headers, since those are C headers.
Comment 1 Chris Dumez 2012-07-17 00:39:41 PDT
Created attachment 152708 [details]

I had to patch the style checking script as well because it would not recognize our header files as being C files and it would complain if we use NULL in them.
Comment 2 Gyuyoung Kim 2012-07-17 04:20:49 PDT
Though we decide to stop to land big coding style change with kubo anymore, EFL folks decides to change one more thing as below,


If possible, I still think we should not change big coding style change anymore. But, this patch needs to be landed.

So, informal rs+ on my side.

Christophe, if this patch is landed, please update this new coding style to WebKit EFL coding style wiki page as well.
Comment 3 WebKit Review Bot 2012-07-17 12:40:45 PDT
Comment on attachment 152708 [details]

Clearing flags on attachment: 152708

Committed r122868: <http://trac.webkit.org/changeset/122868>
Comment 4 WebKit Review Bot 2012-07-17 12:40:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Tony Chang 2012-07-17 15:17:06 PDT
This is causing 3 webkitpy unit tests to fail:

[1030/1444] webkitpy.style.checkers.cpp_unittest.CppStyleTest.test_pointer_reference_marker_location erred:
  Traceback (most recent call last):
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 2012, in test_pointer_reference_marker_location
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 316, in assert_lint
      self.assertEquals(expected_message, self.perform_single_line_lint(code, file_name))
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 270, in perform_single_line_lint
      return self.perform_lint(code, filename, basic_error_rules)
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 259, in perform_lint
      self.process_file_data(filename, extension, lines, error_collector, unit_test_config)
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 253, in process_file_data
      error, self.min_confidence, unit_test_config)
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3652, in process_file_data
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3644, in check
      self.handle_style_error, self.min_confidence)
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3518, in _process_lines
      include_state, function_state, class_state, file_state, error)
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3485, in process_line
      file_state, error)
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3024, in check_language
      check_identifier_name_in_declaration(filename, line_number, line, file_state, error)
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 3122, in check_identifier_name_in_declaration
      if not file_state.is_objective_c() and modified_identifier.find('_') >= 0:
    File "/mnt/data/b/WebKit-BuildSlave/chromium-linux-release-tests/build/Tools/Scripts/webkitpy/style/checkers/cpp.py", line 1184, in is_objective_c
      if self._is_objective_c is None:
  AttributeError: '_FileState' object has no attribute '_is_objective_c'
Comment 6 Dirk Pranke 2012-07-17 16:13:02 PDT
(In reply to comment #5)
> This is causing 3 webkitpy unit tests to fail:

Fixed in http://trac.webkit.org/changeset/122889