Bug 91465 - nrwt: move per-test result output into printing.py
Summary: nrwt: move per-test result output into printing.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-16 19:59 PDT by Dirk Pranke
Modified: 2012-07-17 16:39 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.00 KB, patch)
2012-07-16 20:00 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
add comment about removing dead code (5.23 KB, patch)
2012-07-16 20:03 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
remove unused branch in update_summary_with_result() (5.62 KB, patch)
2012-07-17 11:46 PDT, Dirk Pranke
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-07-16 19:59:48 PDT
nrwt: move per-test result output into printing.py
Comment 1 Dirk Pranke 2012-07-16 20:00:57 PDT
Created attachment 152685 [details]
Patch
Comment 2 Dirk Pranke 2012-07-16 20:03:20 PDT
Created attachment 152686 [details]
add comment about removing dead code
Comment 3 Ojan Vafai 2012-07-17 09:06:58 PDT
Comment on attachment 152686 [details]
add comment about removing dead code

It looks like if you choose trace-everything (which we do on the bots, right?) we now print something for skipped tests where we didn't before. Was that intentional?
Comment 4 Dirk Pranke 2012-07-17 11:37:44 PDT
(In reply to comment #3)
> (From update of attachment 152686 [details])
> It looks like if you choose trace-everything (which we do on the bots, right?) we now print something for skipped tests where we didn't before. Was that intentional?

We don't run with --print trace-everything on the bots. 

However, even if we did, nothing would get printed for skipped tests. update_summary_with_result is only called from handle_finished_test, and so it's only called for tests that are actually run. 

Which means that the 'if result.type == test_expectations.SKIP:' branch is never True :). So I'll delete it. Good catch.
Comment 5 Dirk Pranke 2012-07-17 11:46:11 PDT
Created attachment 152797 [details]
remove unused branch in update_summary_with_result()
Comment 6 Ojan Vafai 2012-07-17 13:26:53 PDT
Comment on attachment 152797 [details]
remove unused branch in update_summary_with_result()

View in context: https://bugs.webkit.org/attachment.cgi?id=152797&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-981
> -        if result.type == test_expectations.SKIP:

Maybe mention in the ChangeLog why it's safe to remove this?
Comment 7 Dirk Pranke 2012-07-17 16:32:12 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 152686 [details] [details])
> > It looks like if you choose trace-everything (which we do on the bots, right?) we now print something for skipped tests where we didn't before. Was that intentional?
> 
> We don't run with --print trace-everything on the bots. 
> 
> However, even if we did, nothing would get printed for skipped tests. update_summary_with_result is only called from handle_finished_test, and so it's only called for tests that are actually run. 
> 
> Which means that the 'if result.type == test_expectations.SKIP:' branch is never True :). So I'll delete it. Good catch.

Ack, I'm wrong. if we skip a test because it was a reftest and --no-ref-tests was on the command line, then we will pass SKIP as a result. I will revert that part of the code, although this seems like a separate bug (we should just be skipping the reftests up front).
Comment 8 Dirk Pranke 2012-07-17 16:33:14 PDT
note that I think it's okay to print this case in --print trace-everything.
Comment 9 Dirk Pranke 2012-07-17 16:39:49 PDT
Committed r122897: <http://trac.webkit.org/changeset/122897>