vertical-align: middle causes overflow with subpixel layout

[Emil A Eklund]

Using vertical-align: middle in combination with an overflow value other than visible can cause the overflow height to be computed incorrectly.

Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=130888

[Emil A Eklund]

Created attachment 152789 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 152789 [details]
Patch

OK.

[Emil A Eklund]

Committed r122883: <http://trac.webkit.org/changeset/122883>

[Jer Noble]

The platform/mac/fast/inline/002-expected.txt and platform/mac/fast/table/table-display-types-strict-expected.txt files added by this commit have been broken since they were committed on the Apple Lion bots.

See:
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/results.html
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/inline/002-pretty-diff.html
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/table/table-display-types-strict-pretty-diff.html

[Emil A Eklund]

(In reply to comment #4)
> The platform/mac/fast/inline/002-expected.txt and platform/mac/fast/table/table-display-types-strict-expected.txt files added by this commit have been broken since they were committed on the Apple Lion bots.
> 
> See:
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/results.html
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/inline/002-pretty-diff.html
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/table/table-display-types-strict-pretty-diff.html

Sorry about that, looking into it now.

[Jer Noble]

Reverted the changes to the platform/mac expected results in http://trac.webkit.org/changeset/123053.

[Emil A Eklund]

Thank you.

[Dominik Röttsches (drott)]

*** Bug 90169 has been marked as a duplicate of this bug. ***