Bug 91458 - [Chromium] Rename HarfBuzzFace to HarfBuzzNGFace
Summary: [Chromium] Rename HarfBuzzFace to HarfBuzzNGFace
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
Depends on:
Reported: 2012-07-16 17:49 PDT by Kenichi Ishibashi
Modified: 2012-07-17 18:12 PDT (History)
2 users (show)

See Also:

Patch (51.12 KB, patch)
2012-07-16 18:39 PDT, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-07-16 17:49:53 PDT
This is a follow-up of https://bugs.webkit.org/show_bug.cgi?id=90362#c15
Comment 1 Kenichi Ishibashi 2012-07-16 18:39:02 PDT
Created attachment 152677 [details]
Comment 2 WebKit Review Bot 2012-07-16 19:10:52 PDT
Attachment 152677 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:39:  hb_face_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:41:  hb_font_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 12 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tony Chang 2012-07-17 10:03:17 PDT
Comment on attachment 152677 [details]

Comment 4 Kenichi Ishibashi 2012-07-17 15:58:16 PDT
Comment on attachment 152677 [details]

Thank you for review!
Comment 5 WebKit Review Bot 2012-07-17 16:39:50 PDT
Comment on attachment 152677 [details]

Rejecting attachment 152677 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t in LayoutTests/platform/mac/TestExpectations
Failed to merge in the changes.
Patch failed at 0001 [Mac] REGRESSION (r122651): fast/text/descent-clip-in-scaled-page.html fails

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13275343
Comment 6 Kenichi Ishibashi 2012-07-17 17:14:24 PDT
Comment on attachment 152677 [details]

Try again.
Comment 7 WebKit Review Bot 2012-07-17 18:12:23 PDT
Comment on attachment 152677 [details]

Clearing flags on attachment: 152677

Committed r122911: <http://trac.webkit.org/changeset/122911>
Comment 8 WebKit Review Bot 2012-07-17 18:12:28 PDT
All reviewed patches have been landed.  Closing bug.