Bug 91458 – [Chromium] Rename HarfBuzzFace to HarfBuzzNGFace

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kenichi Ishibashi]

This is a follow-up of https://bugs.webkit.org/show_bug.cgi?id=90362#c15

[Kenichi Ishibashi]

Created attachment 152677 [details]
Patch

[WebKit Review Bot]

Attachment 152677 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:39:  hb_face_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:41:  hb_font_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tony Chang]

Comment on attachment 152677 [details]
Patch

Thanks!

[Kenichi Ishibashi]

Comment on attachment 152677 [details]
Patch

Thank you for review!

[WebKit Review Bot]

Comment on attachment 152677 [details]
Patch

Rejecting attachment 152677 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t in LayoutTests/platform/mac/TestExpectations
Failed to merge in the changes.
Patch failed at 0001 [Mac] REGRESSION (r122651): fast/text/descent-clip-in-scaled-page.html fails

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13275343

[Kenichi Ishibashi]

Comment on attachment 152677 [details]
Patch

Try again.

[WebKit Review Bot]

Comment on attachment 152677 [details]
Patch

Clearing flags on attachment: 152677

Committed r122911: <http://trac.webkit.org/changeset/122911>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.