Bug 91449 – [Chromium] EventSender shouldn't know about TestShell

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

[Chromium] EventSender shouldn't know about TestShell

[Adam Barth]

Created attachment 152651 [details]
Works except for WebViewHost

[Adam Barth]

We're somewhat blocked on EventSender until we figure out what we're doing with WebViewHost.  I emailed webkit-dev with that question.

[Adam Barth]

Created attachment 153441 [details]
Patch

This patch looks good

[WebKit Review Bot]

Comment on attachment 153441 [details]
Patch

Attachment 153441 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13307211

New failing tests:
editing/pasteboard/copy-standalone-image-crash.html
editing/deleting/skip-virama-001.html
editing/input/page-up-down-scrolls.html
editing/input/caret-at-the-edge-of-input.html
editing/selection/caret-mode-paragraph-keys-navigation.html
editing/deleting/forward-delete-key.html
editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html
editing/input/scroll-viewport-page-up-down.html
editing/input/reveal-caret-of-multiline-input.html
editing/deleting/delete-ligature-002.html
editing/input/password-echo-passnode2.html
editing/deleting/delete-ligature-001.html
editing/deleting/delete-ligature-003.html
editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html
editing/input/password-echo-passnode.html
editing/input/reveal-edit-on-input-vertically.html
editing/selection/button-right-click.html
editing/input/password-echo-passnode3.html
editing/input/password-echo-textnode.html
editing/selection/5354455-2.html
editing/input/reveal-contenteditable-on-input-vertically.html
editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html
editing/input/caret-at-the-edge-of-contenteditable.html
editing/deleting/delete-by-word-001.html
editing/input/style-change-during-input.html
editing/deleting/delete-by-word-002.html
editing/deleting/5729680.html
editing/input/option-page-up-down.html

[WebKit Review Bot]

Created attachment 153456 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Adam Barth]

I borked it!

Comment on attachment 153441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153441&action=review

> Tools/DumpRenderTree/chromium/TestShell.cpp:151
> +    m_eventSender = adoptPtr(new EventSender(webViewHost()));

at this point, webViewHost() returns 0. It will be created later in TestShell::createMainWindow.

[Adam Barth]

Ah, makes sense.

Created attachment 153987 [details]
Patch

[WebKit Review Bot]

Comment on attachment 153987 [details]
Patch

Attachment 153987 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13333324

[Adam Barth]

Comment on attachment 153987 [details]
Patch

This looks like a good solution.  It looks like you have a compile error on Linux to work though.

Created attachment 153989 [details]
Patch

(In reply to comment #12)
> (From update of attachment 153987 [details])
> This looks like a good solution.  It looks like you have a compile error on Linux to work though.

maybe I should include all files in the patch.. I guess that will help compilation

[WebKit Review Bot]

Comment on attachment 153989 [details]
Patch

Clearing flags on attachment: 153989

Committed r123449: <http://trac.webkit.org/changeset/123449>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.