RESOLVED FIXED Bug 91439
nrwt: move a bunch of printing code from manager.py to printing.py 
https://bugs.webkit.org/show_bug.cgi?id=91439
Summary nrwt: move a bunch of printing code from manager.py to printing.py
Dirk Pranke
Reported 2012-07-16 16:01:55 PDT
nrwt: move a bunch of printing code from manager.py to printing.py
Attachments
Patch (34.25 KB, patch)
2012-07-16 16:06 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix typos from review feedback (34.25 KB, patch)
2012-07-16 16:39 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-07-16 16:06:05 PDT
Created attachment 152635 [details] Patch
Ojan Vafai
Comment 2 2012-07-16 16:15:45 PDT
Comment on attachment 152635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152635&action=review > Tools/ChangeLog:10 > + live in printing.py; this patch moves a large chunk of hit that > + prints all of the stuff after the run completes. This sentence is missing some words. Not sure what it's supposed to say. :) > Tools/Scripts/webkitpy/layout_tests/views/printing.py:207 > + directory_test_timings, individual_test_timings, > + result_summary): This indentation is funny > Tools/Scripts/webkitpy/layout_tests/views/printing.py:245 > + result_summary): ditto
Dirk Pranke
Comment 3 2012-07-16 16:39:57 PDT
Created attachment 152642 [details] fix typos from review feedback
Dirk Pranke
Comment 4 2012-07-16 16:46:18 PDT
Committed r122777: <http://trac.webkit.org/changeset/122777>
Note You need to log in before you can comment on or make changes to this bug.