Bug 91414 – IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[David Grogan]

IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types

[David Grogan]

Created attachment 152587 [details]
Patch

[WebKit Review Bot]

Comment on attachment 152587 [details]
Patch

Attachment 152587 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13262069

[David Grogan]

This won't pass cr-linux until 91408 lands.

[David Grogan]

Created attachment 152611 [details]
Patch

[David Grogan]

Created attachment 152612 [details]
Patch

[David Grogan]

Created attachment 152614 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[David Grogan]

Created attachment 152862 [details]
Patch

[David Grogan]

Created attachment 153155 [details]
Patch

[David Grogan]

Josh or Alec, could you take a look at this?

[Joshua Bell]

Comment on attachment 153155 [details]
Patch

LGTM.

Having intVersion be an optional add-on in the API rather than the new default (and thus making the legacy string version optional) means there will be more "clean up" work later on, but this is probably the safest incremental approach to get the new support in and under test.

[Joshua Bell]

abarth@ can you r?

[Adam Barth]

Comment on attachment 153155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153155&action=review

> Source/WebCore/Modules/indexeddb/IDBMetadata.h:50
> +        : intVersion(NoIntVersion) { }

The { } should each be on their own line.

[David Grogan]

Created attachment 153585 [details]
Patch for landing

[David Grogan]

Comment on attachment 153155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153155&action=review

Adam and Josh, thanks for the review.

>> Source/WebCore/Modules/indexeddb/IDBMetadata.h:50
>> +        : intVersion(NoIntVersion) { }
> 
> The { } should each be on their own line.

Done.

[WebKit Review Bot]

Comment on attachment 153585 [details]
Patch for landing

Clearing flags on attachment: 153585

Committed r123267: <http://trac.webkit.org/changeset/123267>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.