Bug 91387 – [CMake][EFL] Building jsc causes reconfiguration

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Thiago Marcos P. Santos]

One of the steps of our build bot calls ./Tools/Scripts/run-javascriptcore-tests which calls ./Tools/Scripts/build-jsc internally.

This script builds the "jsc" target, which is fine. The problem is: we are removing the CMakeCache.txt every time we build a target using the convenience perl script "buildCMakeProjectOrExit". In this case, the whole project is reconfigured using the default build options.

This leads to 2 side effects:

- jsc is rebuilt on the bots every time (since it takes different configuration).
- We are not building and running the WebKit2 unit tests on the bots.

We should remove the cache only when running ./Tools/Scripts/build-webkit.

[Thiago Marcos P. Santos]

Created attachment 152731 [details]
Patch

[Daniel Bates]

Comment on attachment 152731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152731&action=review

OK

> Tools/ChangeLog:9
> +        other it will cause a reconfiguration every time someone calls

Nit: other => otherwise

> Tools/ChangeLog:11
> +        not running WebKit 2 unit tests on the bots because the project was

Nit: WebKit 2 => WebKit2

> Tools/Scripts/webkitdirs.pm:2129
> +    my $config = configuration();
> +    my $buildPath = File::Spec->catdir(baseProductDir(), $config);
> +    my $cacheFilePath = File::Spec->catdir($buildPath, "CMakeCache.txt");

I don't see much value in defining the variables $config and $buildPath that are only used towards building the filesystem path to the appropriate file CMakeCache.txt. I would write this as:

my $cacheFilePath = File::Spec->catdir(baseProductDir(), configuration(), "CMakeCache.txt");

> Tools/Scripts/webkitdirs.pm:2130
> +

Nit: I don't feel that this empty line improves the readability of this function and I suggest that we remove it. The body of this function is concise and straightforward to follow without this empty line.

[Thiago Marcos P. Santos]

Created attachment 152983 [details]
Patch

Thanks a lot for reviewing.

[WebKit Review Bot]

Comment on attachment 152983 [details]
Patch

Clearing flags on attachment: 152983

Committed r122956: <http://trac.webkit.org/changeset/122956>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.