Bug 91373 - Layout Test pointer-lock/locked-element-removed-from-dom.html is flaky on chromium win
Summary: Layout Test pointer-lock/locked-element-removed-from-dom.html is flaky on chr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vincent Scheib
URL:
Keywords:
Depends on:
Blocks: 77029
  Show dependency treegraph
 
Reported: 2012-07-16 04:00 PDT by Vsevolod Vlasov
Modified: 2012-07-16 13:48 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.79 KB, patch)
2012-07-16 12:35 PDT, Vincent Scheib
no flags Details | Formatted Diff | Diff
Patch (3.77 KB, patch)
2012-07-16 12:40 PDT, Vincent Scheib
no flags Details | Formatted Diff | Diff
Patch for landing (3.77 KB, patch)
2012-07-16 12:47 PDT, Vincent Scheib
no flags Details | Formatted Diff | Diff
Patch for landing (3.77 KB, patch)
2012-07-16 12:48 PDT, Vincent Scheib
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-07-16 04:00:20 PDT
The following layout test is flaky on chromium win

pointer-lock/locked-element-removed-from-dom.html

Probable cause:

http://trac.webkit.org/changeset/122626/

flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=pointer-lock%2Flocked-element-removed-from-dom.html

Diff:

--- e:\b\build\slave\Webkit_Win__dbg__2_\build\layout-test-results\pointer-lock/locked-element-removed-from-dom-expected.txt 
+++ e:\b\build\slave\Webkit_Win__dbg__2_\build\layout-test-results\pointer-lock/locked-element-removed-from-dom-actual.txt 
@@ -13,7 +13,6 @@
 PASS document.webkitPointerLockElement is null
 PASS targetDiv1.parentElement.parentElement is null
 PASS onwebkitpointerlockerror received after: Remove targetDiv1's parent from iframe & immediately lock target2. (main document handler)
-PASS onwebkitpointerlockchange received after: Remove targetDiv1's parent from iframe & immediately lock target2. (iframe handler)
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Vsevolod Vlasov 2012-07-16 04:04:24 PDT
http://trac.webkit.org/changeset/122711
Comment 2 Vincent Scheib 2012-07-16 12:35:12 PDT
Created attachment 152588 [details]
Patch
Comment 3 Adrienne Walker 2012-07-16 12:39:21 PDT
Comment on attachment 152588 [details]
Patch

R=me.  Can you re-enable this test when you're landing this?
Comment 4 Vincent Scheib 2012-07-16 12:40:50 PDT
Created attachment 152589 [details]
Patch
Comment 5 WebKit Review Bot 2012-07-16 12:45:08 PDT
Comment on attachment 152589 [details]
Patch

Rejecting attachment 152589 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13264047
Comment 6 Vincent Scheib 2012-07-16 12:47:20 PDT
Created attachment 152590 [details]
Patch for landing
Comment 7 Vincent Scheib 2012-07-16 12:48:32 PDT
Created attachment 152591 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-07-16 13:48:54 PDT
Comment on attachment 152591 [details]
Patch for landing

Clearing flags on attachment: 152591

Committed r122758: <http://trac.webkit.org/changeset/122758>
Comment 9 WebKit Review Bot 2012-07-16 13:48:58 PDT
All reviewed patches have been landed.  Closing bug.