Which makes impossible to make our bots green.
Created attachment 152505 [details] Patch
Comment on attachment 152505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152505&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:486 > except BaseException, e: Shouldn't we catch Exception instead of BaseException ?
(In reply to comment #2) > (From update of attachment 152505 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152505&action=review > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:486 > > except BaseException, e: > > Shouldn't we catch Exception instead of BaseException ? Check bug 91129.
Created attachment 152522 [details] Patch Better name to return code variable.
Comment on attachment 152522 [details] Patch Attachment 152522 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13238934
Comment on attachment 152522 [details] Patch Clearing flags on attachment: 152522 Committed r122728: <http://trac.webkit.org/changeset/122728>
All reviewed patches have been landed. Closing bug.
Comment on attachment 152522 [details] Patch interesting, I didn't realize that (obviously). Thanks for the fix!
*** Bug 91389 has been marked as a duplicate of this bug. ***
webkit_lint is still red on chromium bots. http://build.chromium.org/p/chromium.webkit/waterfall?branch=&builder=Webkit+Win+Builder&builder=Webkit+Win&builder=Webkit+Vista&builder=Webkit+Win7&builder=Webkit+Mac+Builder&builder=Webkit+Mac10.5&builder=Webkit+Mac10.6&builder=Webkit+Mac+Builder+%28CG%29&builder=Webkit+Mac10.5+%28CG%29&builder=Webkit+Mac10.6+%28CG%29&builder=Webkit+Mac10.7&builder=Webkit+Linux&builder=Webkit+Linux+32&reload=none
(In reply to comment #10) > webkit_lint is still red on chromium bots. > > http://build.chromium.org/p/chromium.webkit/waterfall?branch=&builder=Webkit+Win+Builder&builder=Webkit+Win&builder=Webkit+Vista&builder=Webkit+Win7&builder=Webkit+Mac+Builder&builder=Webkit+Mac10.5&builder=Webkit+Mac10.6&builder=Webkit+Mac+Builder+%28CG%29&builder=Webkit+Mac10.5+%28CG%29&builder=Webkit+Mac10.6+%28CG%29&builder=Webkit+Mac10.7&builder=Webkit+Linux&builder=Webkit+Linux+32&reload=none IMO the actual failure is unrelated to this bug. Looks to me it is failing because of this: LayoutTests/platform/chromium/TestExpectations:2885 More specific entry for fast/frames/calculate-fixed.html on line LayoutTests/platform/chromium/TestExpectations:2885 overrides line LayoutTests/platform/chromium/TestExpectations:2883. fast/frames/calculate-fixed.html http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/19523/steps/webkit_lint/logs/stdio
(In reply to comment #11) > (In reply to comment #10) > > webkit_lint is still red on chromium bots. > > > > http://build.chromium.org/p/chromium.webkit/waterfall?branch=&builder=Webkit+Win+Builder&builder=Webkit+Win&builder=Webkit+Vista&builder=Webkit+Win7&builder=Webkit+Mac+Builder&builder=Webkit+Mac10.5&builder=Webkit+Mac10.6&builder=Webkit+Mac+Builder+%28CG%29&builder=Webkit+Mac10.5+%28CG%29&builder=Webkit+Mac10.6+%28CG%29&builder=Webkit+Mac10.7&builder=Webkit+Linux&builder=Webkit+Linux+32&reload=none > > IMO the actual failure is unrelated to this bug. Looks to me it is failing because of this: > > LayoutTests/platform/chromium/TestExpectations:2885 More specific entry for fast/frames/calculate-fixed.html on line LayoutTests/platform/chromium/TestExpectations:2885 overrides line LayoutTests/platform/chromium/TestExpectations:2883. fast/frames/calculate-fixed.html > > http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/19523/steps/webkit_lint/logs/stdio That's correct. Sorry for the noise.