Bug 91337 – DFG PutById transition should handle storage allocation, and inline it

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Work in progress patch forthcoming.

[Filip Pizlo]

Created attachment 152452 [details]
work in progress

[Filip Pizlo]

Created attachment 152465 [details]
more!

Most likely doesn't compile at this point.  The scaffolding is mostly done.  Now it's time to actually write the fast paths.

[Filip Pizlo]

Created attachment 152467 [details]
it's starting to work

It works for very simple programs.  Haven't tried the bigger ones yet.

[Filip Pizlo]

Created attachment 152487 [details]
the patch

[WebKit Review Bot]

Attachment 152487 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGGPRInfo.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/dfg/DFGRegisterSet.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Created attachment 152489 [details]
the patch

Fixed style issues.

[Build Bot]

Comment on attachment 152489 [details]
the patch

Attachment 152489 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13253196

[Early Warning System Bot]

Comment on attachment 152489 [details]
the patch

Attachment 152489 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13253198

[Early Warning System Bot]

Comment on attachment 152489 [details]
the patch

Attachment 152489 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13238862

[Filip Pizlo]

Created attachment 152580 [details]
the patch

Fix build on gcc.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/122768

[Ryosuke Niwa]

This patch broke builds:
http://build.webkit.org/builders/Apple%20SnowLeopard%20Debug%20%28Build%29/builds/1455/steps/compile-webkit/logs/stdio
In file included from /Volumes/Data/slave/snowleopard-debug/build/Source/JavaScriptCore/bytecode/CodeBlock.h:65:
In file included from /Volumes/Data/slave/snowleopard-debug/build/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28:
/Volumes/Data/slave/snowleopard-debug/build/Source/JavaScriptCore/bytecode/StructureStubInfo.h:34:10: fatal error: 'DFGRegisterSet.h' file not found [2]
 #include "DFGRegisterSet.h"
          ^
1 error generated.

[Ryosuke Niwa]

Qt
http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Debug/builds/46297/steps/compile-webkit/logs/stdio
In file included from /home/webkitbuildbot/slaves/windowsCrossDebug/buildslave/qt-windows-32bit-debug/build/Source/JavaScriptCore/bytecode/CodeBlock.h:65:0,
                 from /home/webkitbuildbot/slaves/windowsCrossDebug/buildslave/qt-windows-32bit-debug/build/Source/JavaScriptCore/API/JSCallbackFunction.cpp:31:
/home/webkitbuildbot/slaves/windowsCrossDebug/buildslave/qt-windows-32bit-debug/build/Source/JavaScriptCore/bytecode/StructureStubInfo.h:34:28: fatal error: DFGRegisterSet.h: No such file or directory
compilation terminated.

GTK:
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/26527/steps/compile-webkit/logs/stdio

make: *** No rule to make target `Source/JavaScriptCore/dfg/DFGRegisterSet.h', needed by `DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h'.  Stop.

[Ryosuke Niwa]

It appears that you forgot svn add DFGRegisterSet.h and DFGScratchRegisterAllocator.h?

[Filip Pizlo]

Added forgotten files in http://trac.webkit.org/changeset/122771