Bug 9133 - Split CSSStyleSelector.* into separate files (one class per file).
Summary: Split CSSStyleSelector.* into separate files (one class per file).
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-26 17:32 PDT by Sam Weinig
Modified: 2010-06-11 17:24 PDT (History)
1 user (show)

See Also:

Attachments
patch (404.80 KB, patch)
2006-05-26 17:40 PDT, Sam Weinig 		darin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2006-05-26 17:32:35 PDT 
This one was a little more tricky.
Comment 1 Sam Weinig 2006-05-26 17:40:17 PDT 
Created attachment 8567 [details]
patch

Like the other split patches, this requires the lander to do some work to split the files on their end (ussually just running a script).  It is a little more complicated than some of the others as StyleSelector.h, CSSRuleData.h and CSSRuleDataList.h all do not have implementation (.cpp) files and thus only require cssstyleselector.h to be copied.  In addition, CSSRuleSet.h and CSSRuleSet.cpp come from within cssstyleselector.cpp and require to copies of it.  Lastly, I could not find a way to convert cssstyleselector.h and cssstyleselector.cpp into CSSStyleSelector.h and CSSStyleSelector.cpp due to svn not understanding the case change.
Comment 2 Darin Adler 2006-05-31 14:52:12 PDT 
Comment on attachment 8567 [details]
patch

Looks great.

But there's no patch here for the project files, nor for ChangeLog. Need to include those.
Comment 3 Alexey Proskuryakov 2010-06-11 17:24:38 PDT 
Please feel free to reopen if you'd like to revisit this work.