http://trac.webkit.org/changeset/122665 broke the build: Broke Mac builds (Requested by rniwa on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Created attachment 152419 [details] ROLLOUT of r122665 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Comment on attachment 152419 [details] ROLLOUT of r122665 Clearing flags on attachment: 152419 Committed r122667: <http://trac.webkit.org/changeset/122667>
All reviewed patches have been landed. Closing bug.
This is exactly the situation where the build should have been fixed rather than rolling the patch out. The fix is so trivial (either forward-declare _postCacheModelChangedNotification or move its definition to before the place it is used) and the build failure is specific to older versions of Xcode. Rolling out patches with trivial fixes like this seems completely unnecessary.
(In reply to comment #4) > This is exactly the situation where the build should have been fixed rather than rolling the patch out. The fix is so trivial (either forward-declare _postCacheModelChangedNotification or move its definition to before the place it is used) and the build failure is specific to older versions of Xcode. Rolling out patches with trivial fixes like this seems completely unnecessary. I would have done that if I had known the solution. But I didn't know, and the patch author or anyone else familiar with Obj-C wasn't present at the time. I even waited for half an hour but it was blocking my work so I had to roll it out.
On a somewhat related note, your r122671 broke mac debug builds: http://build.webkit.org/builders/Apple%20SnowLeopard%20Debug%20%28Build%29/builds/1433/steps/compile-webkit/logs/stdio