[chromium] Remove targetRenderSurface concept, give layers a renderTarget which is the layer whose coordinate space they draw into
Created attachment 152341 [details] Patch
Created attachment 152349 [details] rm-surface-filters
Comment on attachment 152341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152341&action=review > Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.h:-111 > - RenderSurfaceChromium* targetRenderSurface() const; > - Nice! > Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:454 > + // The layer owns a surface which is contributing to another target. > + ASSERT(layer->renderTarget() == layer); Comment is kind of misleading. > Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:468 > - const RenderSurfaceType* targetSurface = surface->targetRenderSurface(); > - if (targetSurface) > - surfaceClipRect = intersection(targetSurface->contentRect(), enclosingIntRect(surface->drawableContentRect())); > - else > - surfaceClipRect = m_scissorRectInScreenSpace; > + LayerType* contributingSurfaceRenderTarget = layer->parent()->renderTarget(); > + surfaceClipRect = intersection(contributingSurfaceRenderTarget->renderSurface()->contentRect(), enclosingIntRect(surface->drawableContentRect())); <3
Comment on attachment 152349 [details] rm-surface-filters This is good too. Is there a reason not to just submit these patches separately?
Nope was just wondering what you'd think, and wanted to give a trajectory. I could smoosh them together but no need to, I'll submit them separately then.
Created attachment 152592 [details] Patch fix comment
Comment on attachment 152592 [details] Patch R=me. Nice cleanup. :)
Comment on attachment 152592 [details] Patch Clearing flags on attachment: 152592 Committed r122756: <http://trac.webkit.org/changeset/122756>
All reviewed patches have been landed. Closing bug.