Bug 91288 – [chromium] Remove targetRenderSurface concept, give layers a renderTarget which is the layer whose coordinate space they draw into

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Remove targetRenderSurface concept, give layers a renderTarget which is the layer whose coordinate space they draw into

[Dana Jansens]

Created attachment 152341 [details]
Patch

[Dana Jansens]

Created attachment 152349 [details]
rm-surface-filters

[Adrienne Walker]

Comment on attachment 152341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152341&action=review

> Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.h:-111
> -    RenderSurfaceChromium* targetRenderSurface() const;
> -

Nice!

> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:454
> +    // The layer owns a surface which is contributing to another target.
> +    ASSERT(layer->renderTarget() == layer);

Comment is kind of misleading.

> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:468
> -        const RenderSurfaceType* targetSurface = surface->targetRenderSurface();
> -        if (targetSurface)
> -            surfaceClipRect = intersection(targetSurface->contentRect(), enclosingIntRect(surface->drawableContentRect()));
> -        else
> -            surfaceClipRect = m_scissorRectInScreenSpace;
> +        LayerType* contributingSurfaceRenderTarget = layer->parent()->renderTarget();
> +        surfaceClipRect = intersection(contributingSurfaceRenderTarget->renderSurface()->contentRect(), enclosingIntRect(surface->drawableContentRect()));

<3

[Adrienne Walker]

Comment on attachment 152349 [details]
rm-surface-filters

This is good too.  Is there a reason not to just submit these patches separately?

[Dana Jansens]

Nope was just wondering what you'd think, and wanted to give a trajectory. I could smoosh them together but no need to, I'll submit them separately then.

[Dana Jansens]

Created attachment 152592 [details]
Patch

fix comment

[Adrienne Walker]

Comment on attachment 152592 [details]
Patch

R=me.  Nice cleanup.  :)

[WebKit Review Bot]

Comment on attachment 152592 [details]
Patch

Clearing flags on attachment: 152592

Committed r122756: <http://trac.webkit.org/changeset/122756>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.