Bug 91286 – Remove an always-failing table-wrapping check in RenderObject::addChild

• Status: RESOLVED
• Resolution: FIXED
• Component: Tables

[Julien Chaffraix]

The table wrapping checks in RenderObject::addChild ends with the following snippet:

else if (newChild->isTableCell()) {
    needsTable = !isTableRow();
    // I'm not 100% sure this is the best way to fix this, but without this
    // change we recurse infinitely when trying to render the CSS2 test page:
    // http://www.bath.ac.uk/%7Epy8ieh/internet/eviltests/htmlbodyheadrendering2.html.
    // See Radar 2925291.
    if (needsTable && isTableCell() && !children->firstChild() && !newChild->isTableCell())
        needsTable = false;
}

As we only get into the branch if newChild->isTableCell() so the nested check is always false. The inner check was added in r1147 by Darin and was made obsolete by bug 12066 (circa 2005).

[Julien Chaffraix]

Created attachment 152342 [details]
Proposed removal 1.

[Eric Seidel (no email)]

Comment on attachment 152342 [details]
Proposed removal 1.

LGTM.

[WebKit Review Bot]

Comment on attachment 152342 [details]
Proposed removal 1.

Clearing flags on attachment: 152342

Committed r122642: <http://trac.webkit.org/changeset/122642>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.