Bug 91277 - NodeLists should not invalidate on irreleavnt attribute changes
Summary: NodeLists should not invalidate on irreleavnt attribute changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 89919
  Show dependency treegraph
 
Reported: 2012-07-13 14:06 PDT by Ryosuke Niwa
Modified: 2012-07-13 17:44 PDT (History)
8 users (show)

See Also:


Attachments
Patch (17.28 KB, patch)
2012-07-13 14:33 PDT, Ryosuke Niwa
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-07-13 14:06:25 PDT
Merge invalidateNodeListsCacheAfterAttributeChanged and invalidateNodeListsCacheAfterChildrenChanged
Comment 1 Ryosuke Niwa 2012-07-13 14:33:29 PDT
Created attachment 152330 [details]
Patch
Comment 2 Ojan Vafai 2012-07-13 15:04:10 PDT
Comment on attachment 152330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152330&action=review

> Source/WebCore/dom/ContainerNode.cpp:683
> +    invalidateNodeListCachesInAncestors(0, 0);

Can you create local variables for these 0's so that it's clear what the arguments are?
Comment 3 Ryosuke Niwa 2012-07-13 15:06:44 PDT
Comment on attachment 152330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152330&action=review

Thanks for the review!

>> Source/WebCore/dom/ContainerNode.cpp:683
>> +    invalidateNodeListCachesInAncestors(0, 0);
> 
> Can you create local variables for these 0's so that it's clear what the arguments are?

Oh oops, I meant to add default values of 0 so that we can omit those 0s. Will fix before landing it.
Comment 4 Ryosuke Niwa 2012-07-13 15:44:50 PDT
Committed r122637: <http://trac.webkit.org/changeset/122637>
Comment 5 Ryosuke Niwa 2012-07-13 17:44:38 PDT
Removed an erroneous assertion in http://trac.webkit.org/changeset/122649.