Bug 91264 – EWSTools should be able to build a commit-queue instance from scratch

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

EWSTools should be able to build a commit-queue instance from scratch

[Adam Barth]

Created attachment 152300 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 152300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152300&action=review

LGTM.

> Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh:52
> +gcutil ssh $BOT_ID "sudo apt-get install subversion -y && svn checkout http://svn.webkit.org/repository/webkit/trunk/Tools/EWSTools tools && cd tools && bash configure-svn-auth.sh $SVN_USERNAME $SVN_PASSWORD && bash cold-boot.sh $QUEUE_TYPE $BOT_ID $BUGZILLA_USERNAME $BUGZILLA_PASSWORD"

I'm sure there is a nicer way to do this.  Even just using \ at the end of the line to continue to the next, might make sense...

[Adam Barth]

Comment on attachment 152300 [details]
Patch

Bash line continuations are way to awesome for me.  I can't handle it.

[WebKit Review Bot]

Comment on attachment 152300 [details]
Patch

Rejecting attachment 152300 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/13242186

[Eric Seidel (no email)]

Comment on attachment 152300 [details]
Patch

Seems like we should be able to recover from 500s.

[WebKit Review Bot]

Comment on attachment 152300 [details]
Patch

Clearing flags on attachment: 152300

Committed r122627: <http://trac.webkit.org/changeset/122627>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.