Bug 91247 - [BlackBerry] resetBitmapZoomScale called while zooming preventing pinch zoom
Summary: [BlackBerry] resetBitmapZoomScale called while zooming preventing pinch zoom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jacky Jiang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-13 08:15 PDT by Jacky Jiang
Modified: 2012-07-13 09:14 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.44 KB, patch)
2012-07-13 08:29 PDT, Jacky Jiang
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacky Jiang 2012-07-13 08:15:22 PDT
PR175432.
Gen Mak 2012-07-10 18:29:10 EDT:
Try pinch zooming yahoo.com or wikipedia.com
The page stops zooming while trying to pinch.
I tracked it down to:

void WebView::resetBitmapZoomScale(double scale)
{
...
    setBitmapZooming(false, false);
}

after this we ignore all bitmap zoom messages.
In fact the yahoo page for some reason always calls resetBitmapZoomScale even
without touching it.

resetBitmapZoom is being called by
void BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad()
Comment 1 Jacky Jiang 2012-07-13 08:29:56 PDT
Created attachment 152268 [details]
Patch
Comment 2 Antonio Gomes 2012-07-13 08:55:04 PDT
Comment on attachment 152268 [details]
Patch

As I said on IRC , I dislike this solution: we are putting hacks on top of hacks in my opinion.

Lets rethink this for the future.
Comment 3 Jacky Jiang 2012-07-13 08:59:58 PDT
(In reply to comment #2)
> (From update of attachment 152268 [details])
> As I said on IRC , I dislike this solution: we are putting hacks on top of hacks in my opinion.
> 
> Lets rethink this for the future.
Sure, thanks!
Comment 4 Jacky Jiang 2012-07-13 09:14:00 PDT
Comment on attachment 152268 [details]
Patch

Committed, r122589, http://trac.webkit.org/changeset/122589.