Bug 91239 - Uses gtk-doc tools even when --disable-gtk-doc passed
Summary: Uses gtk-doc tools even when --disable-gtk-doc passed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Alberto Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-13 07:17 PDT by Ross Burton
Modified: 2013-09-14 01:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (615 bytes, patch)
2012-07-13 07:17 PDT, Ross Burton 		no flags Details | Formatted Diff | Diff
Patch (968 bytes, patch)
2013-09-13 11:37 PDT, Alberto Garcia 		mrobinson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Burton 2012-07-13 07:17:19 PDT 
(using webkitgtk 1.8.1)

If I pass --disable-gtk-doc to configure, "make install" errors out because it tries to run gtkdoc-rebase.

This happens in Tools/GNUmakefile.am, install-data-local, after it's installed the HTML documentation.

(our build system doesn't have gtk-doc as it pulls in 

Attaching a patch to wrap this call in "if ENABLE_GTK_DOC".  If you git repo wasn't larger than the internet itself, I'd have sent this as a git patch.

(if this gets accepted, much appreciated if the author email is ross.burton@intel.com)
Comment 1 Ross Burton 2012-07-13 07:17:58 PDT 
Created attachment 152251 [details]
Patch
Comment 2 Alberto Garcia 2013-09-13 11:37:04 PDT 
Created attachment 211570 [details]
Patch

Thanks for the patch, I tested it and it works fine. It just needed a changelog, here it is.
Comment 3 Alberto Garcia 2013-09-14 01:37:31 PDT 
Committed r155758: <http://trac.webkit.org/changeset/155758>