Bug 91223 – [GTK] Silence grep stderr in build-webkit when detecting the current arch

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Emanuele Aina]

Created attachment 152226 [details]
Ignore missing GNUmakefile when detecting previour arch in build-wekit

When run on a clean checkout, `build-webkit' complains that no GNUmakefile exists when trying to detect the previously configured architecture, but in this case there's no previous configuration so the warning is pointless.

Ignoring the error message by redirecting grep stderr to /dev/null should be safe, patch attached.

[Eric Seidel (no email)]

Comment on attachment 152226 [details]
Ignore missing GNUmakefile when detecting previour arch in build-wekit

OK.  But this needs a ChangeLog.

[Emanuele Aina]

Created attachment 206554 [details]
Patch

[Martin Robinson]

Comment on attachment 206554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206554&action=review

> Tools/ChangeLog:6
> +        Reviewed by Eric Seidel.

I think maybe this is a copy and paste error.

[Emanuele Aina]

Created attachment 206556 [details]
Patch

Use OOPS to automatically generate a proper 'Reviewed by' line in the ChangeLog

[Martin Robinson]

Comment on attachment 206556 [details]
Patch

Thanks!

[Emanuele Aina]

(In reply to comment #3)
> > +        Reviewed by Eric Seidel.
> I think maybe this is a copy and paste error.

Erhm, no, since Eric already said OK to the patch and just mentioned the lack of proper ChangeLog entry I assumed it would have been fine to indicate him as reviewer.

But since you taught me about the OOPS magic this seems to be a good candidate to try it out. :D

However, thanks for the reviews!

[Martin Robinson]

Ah, sorry. Didn't see that.

[WebKit Commit Bot]

Comment on attachment 206556 [details]
Patch

Clearing flags on attachment: 206556

Committed r152601: <http://trac.webkit.org/changeset/152601>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.