Bug 91221 - [CMake] Proper handling of ENABLE_API_TESTS build option
Summary: [CMake] Proper handling of ENABLE_API_TESTS build option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks: 90451 90973
  Show dependency tree / graph
 
Reported: 2012-07-13 04:38 PDT by Thiago Marcos P. Santos
Modified: 2012-07-13 10:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.91 KB, patch)
2012-07-13 06:28 PDT, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-07-13 04:38:36 PDT 
Make it reusable across the ports using CMake. We are about to enable the WTF, WebCore and WebKit 2 API's at Tools/TestWebKitAPI and other ports can get it almost for free.
Comment 1 Thiago Marcos P. Santos 2012-07-13 06:28:10 PDT 
Created attachment 152240 [details]
Patch
Comment 2 Chris Dumez 2012-07-13 07:38:23 PDT 
Comment on attachment 152240 [details]
Patch

LGTM.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-07-13 08:04:12 PDT 
Comment on attachment 152240 [details]
Patch

I don't see an option to enable API tests in FeatureLists.pm, so the idea is that these features in WebKitFeatures.cmake, OptionsEfl.cmake and the rest should have their values changed manually?
Comment 4 Thiago Marcos P. Santos 2012-07-13 08:11:20 PDT 
(In reply to comment #3)
> (From update of attachment 152240 [details])
> I don't see an option to enable API tests in FeatureLists.pm, so the idea is that these features in WebKitFeatures.cmake, OptionsEfl.cmake and the rest should have their values changed manually?

It doesn't go to FeatureList.pm because it only makes sense for the cmake build system.

Not manually, you can disable it by doing:
$ Tools/Scripts/build-webkit --efl --cmakearg="-DENABLE_API_TESTS=OFF"
Comment 5 Rob Buis 2012-07-13 08:20:33 PDT 
Comment on attachment 152240 [details]
Patch

Looks good, thanks for doing this work, BlackBerry port also wants to enable this soonish.
Comment 6 WebKit Review Bot 2012-07-13 10:25:29 PDT 
Comment on attachment 152240 [details]
Patch

Clearing flags on attachment: 152240

Committed r122601: <http://trac.webkit.org/changeset/122601>
Comment 7 WebKit Review Bot 2012-07-13 10:25:34 PDT 
All reviewed patches have been landed.  Closing bug.