Bug 91220 - [GTK] WebKit2 crash when going back/forward
Summary: [GTK] WebKit2 crash when going back/forward
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Critical
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 91482
  Show dependency tree / graph
 
Reported: 2012-07-13 04:32 PDT by Carlos Garcia Campos
Modified: 2012-07-17 03:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.41 KB, patch)
2012-07-13 04:41 PDT, Carlos Garcia Campos 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-07-13 04:32:29 PDT 
I assumed that when load-committed signal is emitted for the main frame, the signals for the main resource had already been fired. That's indeed what happens when the page is normally loaded, but when the page is loaded from the backforward list, we don't even have a main resource when the loadcommitted signal is emitted.
Comment 1 Carlos Garcia Campos 2012-07-13 04:41:11 PDT 
Created attachment 152219 [details]
Patch

Patch to fix the crash, I'll file a new bug for the callbacks emisson order issue.
Comment 2 WebKit Review Bot 2012-07-13 04:44:03 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Xan Lopez 2012-07-13 05:00:36 PDT 
Comment on attachment 152219 [details]
Patch

OK.
Comment 4 Carlos Garcia Campos 2012-07-13 05:08:19 PDT 
Committed r122567: <http://trac.webkit.org/changeset/122567>