Bug 91217 - [CallWith=XXX] arguments should be placed at the head of method arguments
Summary: [CallWith=XXX] arguments should be placed at the head of method arguments
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Reported: 2012-07-13 04:21 PDT by Kentaro Hara
Modified: 2012-07-13 11:16 PDT (History)
7 users (show)

See Also:

Patch (8.68 KB, patch)
2012-07-13 04:34 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-07-13 04:21:17 PDT
The EFL build with the ENABLE_FILE_SYSTEM flag caused a build error, because CodeGeneratorJS.pm assumes webkitEntries(ScriptExecutionContext*, HTMLInputElement*) but the actual signature is webkitEntries(HTMLInputElement*, ScriptExecutionContext*) (bug 91185).

Per https://trac.webkit.org/wiki/WebKitIDL#CallWith, [CallWith=XXX] arguments should be placed at the head of the arguments. (i.e. the behavior of CodeGeneratorJS.pm is correct.)

Thus the correct fix is (1) to change the signature of webkitEntries() and webkitGetAsEntry() so that ScriptExecutionContext* comes first and (2) to modify CodeGeneratorV8.pm to support the order.
Comment 1 Kentaro Hara 2012-07-13 04:34:42 PDT
Created attachment 152217 [details]
Comment 2 WebKit Review Bot 2012-07-13 11:16:05 PDT
Comment on attachment 152217 [details]

Clearing flags on attachment: 152217

Committed r122608: <http://trac.webkit.org/changeset/122608>
Comment 3 WebKit Review Bot 2012-07-13 11:16:10 PDT
All reviewed patches have been landed.  Closing bug.