Bug 91198 - CodeGeneratorJS.pm : SetterExpression should use 'push' rather than 'unshift'
Summary: CodeGeneratorJS.pm : SetterExpression should use 'push' rather than 'unshift'
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-07-13 00:28 PDT by Dongwoo Joshua Im (dwim)
Modified: 2012-07-13 04:04 PDT (History)
6 users (show)

See Also:

Patch (1.62 KB, patch)
2012-07-13 00:40 PDT, Dongwoo Joshua Im (dwim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dongwoo Joshua Im (dwim) 2012-07-13 00:28:36 PDT
Regarding CodeGeneratorV8.pm, 
'SetterExpression' should 'push' to make arguments, rather than 'unshift'.

I'll upload the patch soon.
Comment 1 Dongwoo Joshua Im (dwim) 2012-07-13 00:40:57 PDT
Created attachment 152171 [details]

This is also needed to fix.
Comment 2 Kentaro Hara 2012-07-13 00:48:08 PDT
Comment on attachment 152171 [details]

Sounds reasonable. (Although I don't know there is a use case affected by this change.)
Comment 3 WebKit Review Bot 2012-07-13 02:05:37 PDT
Comment on attachment 152171 [details]

Clearing flags on attachment: 152171

Committed r122553: <http://trac.webkit.org/changeset/122553>
Comment 4 WebKit Review Bot 2012-07-13 02:05:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Thiago Marcos P. Santos 2012-07-13 03:28:17 PDT
Bindings generation tests are failing after this patch:

Comment 6 Kentaro Hara 2012-07-13 04:04:29 PDT
This was a wrong fix.

Rolled out at r122553.