Bug 91194 - enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support
Summary: enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Wei James (wistoch)
URL:
Keywords:
Depends on:
Blocks: 88658
  Show dependency treegraph
 
Reported: 2012-07-12 23:47 PDT by Wei James (wistoch)
Modified: 2012-07-13 20:40 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.75 KB, patch)
2012-07-12 23:48 PDT, Wei James (wistoch)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wei James (wistoch) 2012-07-12 23:47:30 PDT
enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support
Comment 1 Wei James (wistoch) 2012-07-12 23:48:29 PDT
Created attachment 152162 [details]
Patch
Comment 2 Wei James (wistoch) 2012-07-13 00:54:08 PDT
by default, the .so will be put into armeabi folder. adding --app-abi option will put the native binary to correct place.
Comment 3 Peter Beverloo 2012-07-13 06:13:12 PDT
LGTM, thank you for doing this!
Comment 4 Adam Barth 2012-07-13 10:18:23 PDT
Comment on attachment 152162 [details]
Patch

If Peter says this patch is good, that's enough for me.  :)
Comment 5 WebKit Review Bot 2012-07-13 10:57:58 PDT
Comment on attachment 152162 [details]
Patch

Clearing flags on attachment: 152162

Committed r122606: <http://trac.webkit.org/changeset/122606>
Comment 6 WebKit Review Bot 2012-07-13 10:58:03 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Wei James (wistoch) 2012-07-13 20:40:57 PDT
peter, abarth, 

thanks. 

James