Bug 91171 – Chrome/Skia: PDF print output does not have clickable links.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Steve VanDeBogart]

GraphicsContext::setURLForRect is not implemented for Skia so print output does not have clickable links.

[Steve VanDeBogart]

Created attachment 152305 [details]
Patch

[WebKit Review Bot]

Comment on attachment 152305 [details]
Patch

Attachment 152305 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13242174

[Stephen White]

Comment on attachment 152305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152305&action=review

Have you also rolled forward Chromium DEPS, so that the build.webkit.org builders don't break?

> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:1000
>  void GraphicsContext::setURLForRect(const KURL& link, const IntRect& destRect)
>  {
> +    SkAutoDataUnref url(SkData::NewWithCString(link.string().utf8().data()));

Should this be protected by an if (paintingDisabled()) return; as is done on other platforms?

[Steve VanDeBogart]

Created attachment 152325 [details]
Patch

[Steve VanDeBogart]

Comment on attachment 152305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152305&action=review

>> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:1000
>> +    SkAutoDataUnref url(SkData::NewWithCString(link.string().utf8().data()));
> 
> Should this be protected by an if (paintingDisabled()) return; as is done on other platforms?

Thanks. Done.

Also rolled the Chromium DEPS.

[Stephen White]

Comment on attachment 152325 [details]
Patch

Looks good.  r=me

[WebKit Review Bot]

Comment on attachment 152325 [details]
Patch

Attachment 152325 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13242260

New failing tests:
jquery/manipulation.html

[WebKit Review Bot]

Created attachment 152365 [details]
Archive of layout-test-results from gce-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Steve VanDeBogart]

Created attachment 152863 [details]
Patch

[Stephen White]

Comment on attachment 152863 [details]
Patch

OK.  r=me

[WebKit Review Bot]

Comment on attachment 152863 [details]
Patch

Clearing flags on attachment: 152863

Committed r122984: <http://trac.webkit.org/changeset/122984>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tony Chang]

This is causing a link failure on Chromium Win:

13>     Creating library ../../../../..\build\Debug\lib\webkit.lib and object ../../../../..\build\Debug\lib\webkit.exp
13>webcore_platform.lib(GraphicsContextSkia.obj) : error LNK2019: unresolved external symbol "public: static class SkData * __cdecl SkData::NewWithCString(char const * const)" (?NewWithCString@SkData@@SAPAV1@QBD@Z) referenced in function "public: void __thiscall WebCore::GraphicsContext::setURLForRect(class WebCore::KURL const &,class WebCore::IntRect const &)" (?setURLForRect@GraphicsContext@WebCore@@QAEXABVKURL@2@ABVIntRect@2@@Z)
13>../../../../..\build\Debug\webkit.dll : fatal error LNK1120: 1 unresolved externals
13>
13>Build FAILED.

[Tony Chang]

Reverted r122984 for reason:

Broken the shared build, need to export a SkData in skia

Committed r122991: <http://trac.webkit.org/changeset/122991>

[Steve VanDeBogart]

The fix for the shared build problem was committed in Skia 4658.  Chromium Deps is at 147759 which lists skia 4683 (>4658) as a dep.  So this should be fixed now.  What's the easiest way to reland the most recent patch?

[Stephen White]

Comment on attachment 152863 [details]
Patch

Re-setting R+ and CQ+ should do it.  (r=me)

[WebKit Review Bot]

Comment on attachment 152863 [details]
Patch

Clearing flags on attachment: 152863

Committed r123356: <http://trac.webkit.org/changeset/123356>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.