RESOLVED FIXED 91170
webkitpy: make worker.start() and worker.stop() optional in the messagepool 
https://bugs.webkit.org/show_bug.cgi?id=91170
Summary webkitpy: make worker.start() and worker.stop() optional in the messagepool
Dirk Pranke
Reported 2012-07-12 17:32:21 PDT
webkitpy: make worker.start() and worker.stop() optional in the messagepool
Attachments
Patch (2.32 KB, patch)
2012-07-12 17:37 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-07-12 17:37:55 PDT
Created attachment 152109 [details] Patch
Ojan Vafai
Comment 2 2012-07-13 09:31:24 PDT
Comment on attachment 152109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152109&action=review > Tools/Scripts/webkitpy/common/message_pool.py:212 > + if hasattr(self._worker, 'stop'): Does "if self.worker.stop" throw an undefined error or something?
Dirk Pranke
Comment 3 2012-07-13 09:58:46 PDT
(In reply to comment #2) > (From update of attachment 152109 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152109&action=review > > > Tools/Scripts/webkitpy/common/message_pool.py:212 > > + if hasattr(self._worker, 'stop'): > > Does "if self.worker.stop" throw an undefined error or something? Yes.
Dirk Pranke
Comment 4 2012-07-13 12:11:42 PDT
Committed r122618: <http://trac.webkit.org/changeset/122618>
Note You need to log in before you can comment on or make changes to this bug.