Bug 91170 - webkitpy: make worker.start() and worker.stop() optional in the messagepool
Summary: webkitpy: make worker.start() and worker.stop() optional in the messagepool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 17:32 PDT by Dirk Pranke
Modified: 2012-07-13 12:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2012-07-12 17:37 PDT, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-07-12 17:32:21 PDT 
webkitpy: make worker.start() and worker.stop() optional in the messagepool
Comment 1 Dirk Pranke 2012-07-12 17:37:55 PDT 
Created attachment 152109 [details]
Patch
Comment 2 Ojan Vafai 2012-07-13 09:31:24 PDT 
Comment on attachment 152109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152109&action=review

> Tools/Scripts/webkitpy/common/message_pool.py:212
> +            if hasattr(self._worker, 'stop'):

Does "if self.worker.stop" throw an undefined error or something?
Comment 3 Dirk Pranke 2012-07-13 09:58:46 PDT 
(In reply to comment #2)
> (From update of attachment 152109 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=152109&action=review
> 
> > Tools/Scripts/webkitpy/common/message_pool.py:212
> > +            if hasattr(self._worker, 'stop'):
> 
> Does "if self.worker.stop" throw an undefined error or something?

Yes.
Comment 4 Dirk Pranke 2012-07-13 12:11:42 PDT 
Committed r122618: <http://trac.webkit.org/changeset/122618>