Bug 91164 - Move m_type and m_hasNameCache from HTMLCollectionCacheBase to DynamicNodeListCacheBase for better bit packing
Summary: Move m_type and m_hasNameCache from HTMLCollectionCacheBase to DynamicNodeLis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 89919
  Show dependency tree / graph
 
Reported: 2012-07-12 16:39 PDT by Ryosuke Niwa
Modified: 2012-07-12 17:35 PDT (History)
10 users (show)

See Also:

Attachments
Patch (9.64 KB, patch)
2012-07-12 16:44 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Removed the bits from the future (9.45 KB, patch)
2012-07-12 16:47 PDT, Ryosuke Niwa 		andersca: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-07-12 16:39:17 PDT 
Move m_collectionType and m_isNameCacheValid from HTMLCollectionCacheBase to DynamicNodeListCacheBase for better bit packing
Comment 1 Ryosuke Niwa 2012-07-12 16:44:16 PDT 
Created attachment 152095 [details]
Patch
Comment 2 Ryosuke Niwa 2012-07-12 16:46:05 PDT 
Comment on attachment 152095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152095&action=review

> Source/WebCore/html/HTMLCollection.cpp:73
> +    case InvalidCollectionType:
> +        break;

Oops, this shouldn't be here. I'm getting ahead of myself.
Comment 3 Ryosuke Niwa 2012-07-12 16:47:12 PDT 
Created attachment 152097 [details]
Removed the bits from the future
Comment 4 Gyuyoung Kim 2012-07-12 16:52:16 PDT 
Comment on attachment 152097 [details]
Removed the bits from the future

Attachment 152097 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13230005
Comment 5 Ryosuke Niwa 2012-07-12 16:58:05 PDT 
Oh oops, I did need InvalidCollectionType in DynamicNodeListCacheBase. Will add back & make sure it builds before landing it.
Comment 6 Early Warning System Bot 2012-07-12 17:02:20 PDT 
Comment on attachment 152097 [details]
Removed the bits from the future

Attachment 152097 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13221423
Comment 7 Build Bot 2012-07-12 17:03:32 PDT 
Comment on attachment 152097 [details]
Removed the bits from the future

Attachment 152097 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13221422
Comment 8 Build Bot 2012-07-12 17:04:29 PDT 
Comment on attachment 152097 [details]
Removed the bits from the future

Attachment 152097 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13203909
Comment 9 Early Warning System Bot 2012-07-12 17:09:59 PDT 
Comment on attachment 152097 [details]
Removed the bits from the future

Attachment 152097 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13209932
Comment 10 WebKit Review Bot 2012-07-12 17:12:31 PDT 
Comment on attachment 152097 [details]
Removed the bits from the future

Attachment 152097 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13202879
Comment 11 Ryosuke Niwa 2012-07-12 17:20:50 PDT 
Committed r122531: <http://trac.webkit.org/changeset/122531>
Comment 12 Ryosuke Niwa 2012-07-12 17:35:13 PDT 
Apparently gcc doesn't catch all warnings :(

I've landed a build fix in r122533.