Bug 91156 - Fix QtWebKit build with OpenGLES after GC3D/E3D refactor
Summary: Fix QtWebKit build with OpenGLES after GC3D/E3D refactor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 15:30 PDT by Lauro Moura Maranhao Neto
Modified: 2012-07-13 08:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.71 KB, patch)
2012-07-12 16:18 PDT, Lauro Moura Maranhao Neto 		no flags Details | Formatted Diff | Diff
Patch for landing (11.88 KB, patch)
2012-07-12 17:37 PDT, Lauro Moura Maranhao Neto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura Maranhao Neto 2012-07-12 15:30:25 PDT 
After r122250 the Qt port fails to build with several errors. A partial fix was landed in 91030.

Already working on this.
Comment 1 Lauro Moura Maranhao Neto 2012-07-12 16:18:44 PDT 
Created attachment 152089 [details]
Patch
Comment 2 Noam Rosenthal 2012-07-12 16:47:50 PDT 
Comment on attachment 152089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152089&action=review

This looks good to me, but before landing I want to understand why reshapeFBOs was removed in the first place.

> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:73
> +    // unsupported

Call notImplemented() instead of a comment.
Comment 3 Lauro Moura Maranhao Neto 2012-07-12 17:37:22 PDT 
Created attachment 152108 [details]
Patch for landing
Comment 4 Joshua Netterfield 2012-07-13 07:03:31 PDT 
I thought that reshapeFBOs was BlackBerry-specific because in our downstream repo it was blocked by '#if PLATFORM(BLACKBERRY)'. Sorry about that.
Comment 5 WebKit Review Bot 2012-07-13 08:52:10 PDT 
Comment on attachment 152108 [details]
Patch for landing

Clearing flags on attachment: 152108

Committed r122586: <http://trac.webkit.org/changeset/122586>
Comment 6 WebKit Review Bot 2012-07-13 08:52:16 PDT 
All reviewed patches have been landed.  Closing bug.