WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 91668
91148
[V8] Replaceable WebIDL attributes are broken
https://bugs.webkit.org/show_bug.cgi?id=91148
Summary
[V8] Replaceable WebIDL attributes are broken
Erik Arvidsson
Reported
2012-07-12 14:16:59 PDT
DOMWindow.idl has a bunch of [Replaceable] attributes. This means that the js property should be writable and setting the property should just replace the property. The following shouldBe* both fails. window.innerHeight = 42; shouldBe('window.innerHeight', '42'); shouldBeTrue('Object.getOwnPropertyDescriptor(window, "innerHeight").writable)'); Once we implement
bug 49739
the setter needs to defineProperty on the this object. Something like { get: function() { return impl->innerHeight() }, set: function(v) { Object.defineProperty({ value: v, writable: true ... } ... } Right now we only have a get interceptor. I think we can get by using a set interceptor that calls ForceSet but it is possible that we also have to Delete the old property.
Attachments
Add attachment
proposed patch, testcase, etc.
Erik Arvidsson
Comment 1
2012-07-12 14:20:08 PDT
Sorry, this is only a problem with es5_readonly which we are trying to turn on.
Erik Arvidsson
Comment 2
2012-07-19 11:56:59 PDT
*** This bug has been marked as a duplicate of
bug 91668
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug