Bug 91144 - Merge HTMLCollectionWithArrayStorage into HTMLCollection
Summary: Merge HTMLCollectionWithArrayStorage into HTMLCollection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 89919
  Show dependency treegraph
 
Reported: 2012-07-12 13:46 PDT by Ryosuke Niwa
Modified: 2012-07-16 10:06 PDT (History)
9 users (show)

See Also:


Attachments
Patch (19.27 KB, patch)
2012-07-12 15:19 PDT, Ryosuke Niwa
gns: commit-queue-
Details | Formatted Diff | Diff
Patch (19.36 KB, patch)
2012-07-12 15:30 PDT, Ryosuke Niwa
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-07-12 13:46:19 PDT
http://trac.webkit.org/changeset/122345 introduced HTMLCollectionWithArrayStorage to share more code between HTMLFormCollection::item and HTMLPropertiesCollection::item. But we can do better by merging it to HTMLCollection::item. In fact, we can also get rid of HTMLCollection::calcLength as well.
Comment 1 Ryosuke Niwa 2012-07-12 15:19:17 PDT
Created attachment 152076 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-07-12 15:26:30 PDT
Comment on attachment 152076 [details]
Patch

Attachment 152076 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13202856
Comment 3 Ryosuke Niwa 2012-07-12 15:28:52 PDT
Comment on attachment 152076 [details]
Patch

(In reply to comment #2)
> (From update of attachment 152076 [details])
> Attachment 152076 [details] did not pass gtk-ews (gtk):
> Output: http://queues.webkit.org/results/13202856

Oh, oops. A bad merge :( Fixing now.
Comment 4 Ryosuke Niwa 2012-07-12 15:30:14 PDT
Created attachment 152080 [details]
Patch
Comment 5 Ryosuke Niwa 2012-07-12 15:40:30 PDT
Committed r122518: <http://trac.webkit.org/changeset/122518>
Comment 6 Vsevolod Vlasov 2012-07-16 05:53:32 PDT
FYI this change causes http://code.google.com/p/chromium/issues/detail?id=137488
Comment 7 Ryosuke Niwa 2012-07-16 10:06:36 PDT
(In reply to comment #6)
> FYI this change causes http://code.google.com/p/chromium/issues/detail?id=137488

Ah, I think I know what's happening there. Try adding arrayOffset = 0 to
http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLCollection.cpp?rev=122518#L323