RESOLVED FIXED 91143
[BlackBerry] Upstream WebGL Code 
https://bugs.webkit.org/show_bug.cgi?id=91143
Summary [BlackBerry] Upstream WebGL Code
Joshua Netterfield
Reported 2012-07-12 13:27:48 PDT
Upstream WebGL code for BlackBerry port
Attachments
Patch (39.04 KB, patch)
2012-07-13 15:12 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (32.55 KB, patch)
2012-07-16 08:20 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (31.99 KB, patch)
2012-07-16 08:47 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (32.08 KB, patch)
2012-07-16 09:53 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (30.29 KB, patch)
2012-07-16 12:11 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Joshua Netterfield
Comment 1 2012-07-13 15:12:03 PDT
Created attachment 152350 [details] Patch
Joshua Netterfield
Comment 2 2012-07-13 15:28:27 PDT
Will revert changes to readPixels Monday.
Joshua Netterfield
Comment 3 2012-07-16 08:20:28 PDT
Created attachment 152538 [details] Patch
Rob Buis
Comment 4 2012-07-16 08:39:49 PDT
Comment on attachment 152538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152538&action=review Still some things to cleanup. > Source/WebCore/ChangeLog:3 > + This patch includes BlackBerry-specific fixes for anti-aliasing, logging, and shader compilation. This line should go below the Reviewed by line. > Source/WebCore/ChangeLog:23 > + * platform/graphics/opengl/Extensions3DOpenGL.h: Remove unnecessary whitespace. Remove unnecessary whitespace. <- there is unnecessary whitespace in that sentence. > Source/WebKit/ChangeLog:3 > + This patch includes BlackBerry-specific fixes for anti-aliasing, logging, and shader compilation. This line should go below the Reviewed by line. > Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:142 > +#endif Better add some whitespace in some of these lines. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:53 > + // Currently only format=RGBA, type=UNSIGNED_BYTE is supported by the specification: http://www.khronos.org/reg Huh? gives 404
Joshua Netterfield
Comment 5 2012-07-16 08:47:19 PDT
Created attachment 152543 [details] Patch
Joshua Netterfield
Comment 6 2012-07-16 09:53:04 PDT
Created attachment 152554 [details] Patch
Joshua Netterfield
Comment 7 2012-07-16 12:11:05 PDT
Created attachment 152582 [details] Patch
Rob Buis
Comment 8 2012-07-16 12:52:59 PDT
Comment on attachment 152582 [details] Patch Ok.
WebKit Review Bot
Comment 9 2012-07-16 13:29:19 PDT
Comment on attachment 152582 [details] Patch Clearing flags on attachment: 152582 Committed r122754: <http://trac.webkit.org/changeset/122754>
WebKit Review Bot
Comment 10 2012-07-16 13:29:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.