Bug 91131 - Move markers from RenderSVGShape to RenderSVGPath
Summary: Move markers from RenderSVGShape to RenderSVGPath
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philip Rogers
URL:
Keywords:
Depends on:
Blocks: 88231
  Show dependency tree / graph
 
Reported: 2012-07-12 11:56 PDT by Philip Rogers
Modified: 2012-07-12 16:59 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rogers 2012-07-12 11:56:40 PDT 
The SVG spec only allows markers on paths but our current codebase has the code in RenderSVGShape, the superclass of RenderSVGRect and RenderSVGEllipse. Neither rects nor ellipses can have markers so we should move the marker code into RenderSVGPath for better code clarity and rendering performance.
Comment 1 Stephen Chenney 2012-07-12 12:05:38 PDT 
The SVG 2.0 spec will allow more variants of markers, and I think it includes markers an any shape. Check before doing this.
Comment 2 Philip Rogers 2012-07-12 16:59:03 PDT 
(In reply to comment #1)
> The SVG 2.0 spec will allow more variants of markers, and I think it includes markers an any shape. Check before doing this.

I poked around the W3C and I think what is being proposed is more general markers (essentially, <use>) and stuff like shapes along paths but not markers along shapes. It does make sense to use shapes to stroke a shape though, so I will hold off on this patch for now.

Dirk, Niko, do either of you know more information?