Bug 91121 - [BlackBerry] Update about:* pages
Summary: [BlackBerry] Update about:* pages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 11:09 PDT by Joshua Netterfield
Modified: 2012-07-13 07:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (29.21 KB, patch)
2012-07-12 12:58 PDT, Joshua Netterfield
no flags Details | Formatted Diff | Diff
Patch (30.04 KB, patch)
2012-07-12 13:09 PDT, Joshua Netterfield
no flags Details | Formatted Diff | Diff
Patch (30.12 KB, patch)
2012-07-12 13:21 PDT, Joshua Netterfield
no flags Details | Formatted Diff | Diff
Patch (29.69 KB, patch)
2012-07-12 13:49 PDT, Joshua Netterfield
no flags Details | Formatted Diff | Diff
Patch (29.71 KB, patch)
2012-07-13 06:26 PDT, Joshua Netterfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Netterfield 2012-07-12 11:09:08 PDT
Update about:config page to match recent defines, and improve the aesthetics of the about:build, about:version, about:credits, about:memory, about:config, and similar pages.
Comment 1 Joshua Netterfield 2012-07-12 12:58:12 PDT
Created attachment 152032 [details]
Patch
Comment 2 Joshua Netterfield 2012-07-12 13:09:39 PDT
Created attachment 152038 [details]
Patch
Comment 3 Yong Li 2012-07-12 13:13:39 PDT
Comment on attachment 152038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152038&action=review

> Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:47
> +static int strcmpNatural(const char *a, const char *b)
> +{
> +    for (; *a == *b && *a; ++a, ++b) { }
> +    if (*a >= '0' && *a <= '9' && *b >= 'A')
> +        return 1;
> +    if (*b >= '0' && *b <= '9' && *a >= 'A')
> +        return -1;
> +    return *b - *a;
> +}

Can you add some description for this function?
Comment 4 Joshua Netterfield 2012-07-12 13:21:13 PDT
Created attachment 152043 [details]
Patch
Comment 5 Joshua Netterfield 2012-07-12 13:49:11 PDT
Created attachment 152049 [details]
Patch
Comment 6 Yong Li 2012-07-12 14:21:13 PDT
Comment on attachment 152049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152049&action=review

r+ with the copyright line fixed

> Source/WebKit/blackberry/WebCoreSupport/AboutTemplate.html.cpp:3
> + * Copyright (C) 2010, 2011 Research In Motion Limited. All rights reserved.
> + *

should include 2012?
Comment 7 Joshua Netterfield 2012-07-13 06:26:20 PDT
Created attachment 152239 [details]
Patch
Comment 8 WebKit Review Bot 2012-07-13 07:00:20 PDT
Comment on attachment 152239 [details]
Patch

Clearing flags on attachment: 152239

Committed r122573: <http://trac.webkit.org/changeset/122573>
Comment 9 WebKit Review Bot 2012-07-13 07:00:27 PDT
All reviewed patches have been landed.  Closing bug.