Bug 91121 – [BlackBerry] Update about:* pages

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Joshua Netterfield]

Update about:config page to match recent defines, and improve the aesthetics of the about:build, about:version, about:credits, about:memory, about:config, and similar pages.

[Joshua Netterfield]

Created attachment 152032 [details]
Patch

[Joshua Netterfield]

Created attachment 152038 [details]
Patch

[Yong Li]

Comment on attachment 152038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152038&action=review

> Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:47
> +static int strcmpNatural(const char *a, const char *b)
> +{
> +    for (; *a == *b && *a; ++a, ++b) { }
> +    if (*a >= '0' && *a <= '9' && *b >= 'A')
> +        return 1;
> +    if (*b >= '0' && *b <= '9' && *a >= 'A')
> +        return -1;
> +    return *b - *a;
> +}

Can you add some description for this function?

[Joshua Netterfield]

Created attachment 152043 [details]
Patch

[Joshua Netterfield]

Created attachment 152049 [details]
Patch

[Yong Li]

Comment on attachment 152049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152049&action=review

r+ with the copyright line fixed

> Source/WebKit/blackberry/WebCoreSupport/AboutTemplate.html.cpp:3
> + * Copyright (C) 2010, 2011 Research In Motion Limited. All rights reserved.
> + *

should include 2012?

[Joshua Netterfield]

Created attachment 152239 [details]
Patch

[WebKit Review Bot]

Comment on attachment 152239 [details]
Patch

Clearing flags on attachment: 152239

Committed r122573: <http://trac.webkit.org/changeset/122573>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.