Bug 91111 - Move TextureMapperAnimation and texmap/LayerTransform to platform/graphics
Summary: Move TextureMapperAnimation and texmap/LayerTransform to platform/graphics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 09:49 PDT by Noam Rosenthal
Modified: 2012-07-12 11:14 PDT (History)
3 users (show)

See Also:


Attachments
Patch (52.59 KB, patch)
2012-07-12 09:57 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (52.58 KB, patch)
2012-07-12 10:23 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-07-12 09:49:59 PDT
Move TextureMapperAnimation and texmap/LayerTransform to platform/graphics
Comment 1 Noam Rosenthal 2012-07-12 09:57:37 PDT
Created attachment 151979 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-07-12 10:03:29 PDT
Comment on attachment 151979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151979&action=review

> Source/WebCore/ChangeLog:10
> +        TextureMapperAnimation and LayerTransform are not specific to TextureMapper, and we want
> +        to use them for other purposes as well. Moving them to platform/graphics would make that
> +        more explicit.

What about a namechange then to the former?

> Source/WebCore/GNUmakefile.list.am:6128
> +	Source/WebCore/platform/graphics/GraphicsLayerTransform.cpp \
> +	Source/WebCore/platform/graphics/GraphicsLayerTransform.h \
> +	Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp \
> +	Source/WebCore/platform/graphics/GraphicsLayerAnimation.h \

ah you did that :-)

> Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp:27
> +#if USE(TEXTURE_MAPPER)
> +namespace WebCore {

You still want this guard?
Comment 3 Noam Rosenthal 2012-07-12 10:23:01 PDT
Created attachment 151987 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-07-12 11:14:25 PDT
Comment on attachment 151987 [details]
Patch for landing

Clearing flags on attachment: 151987

Committed r122484: <http://trac.webkit.org/changeset/122484>
Comment 5 WebKit Review Bot 2012-07-12 11:14:30 PDT
All reviewed patches have been landed.  Closing bug.