Bug 91100 – [GTK] Add API to get HTTPS status to WebKit2 GTK+

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

Add webkit_uri_response_get_https_status() similar to soup_message_get_https_status().

[Carlos Garcia Campos]

Created attachment 151967 [details]
Patch

This patch doesn't depend on bug #90267. It implements PlatformCertificateInfo for soup and adds API to get the HTTPS status from the WebKitURIResponse.

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Review Bot]

Attachment 151967 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/go..." exit_code: 1
Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp:41:  Use 0 instead of NULL.  [readability/null] [5]
Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp:93:  Use 0 instead of NULL.  [readability/null] [5]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.h"
Total errors found: 2 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 151967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151967&action=review

> Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp:26
> +WebKitTestServer::WebKitTestServer(bool ssl)

I think it would be nice to use an enum here, so that instantiating a server looks like this:

WebKitTestServer(EnableSSL)

or something similar.

[Carlos Garcia Campos]

Committed r122547: <http://trac.webkit.org/changeset/122547>