Bug 91096 - Web Inspector: fix instrumentation code for the bindings instrumentation
Summary: Web Inspector: fix instrumentation code for the bindings instrumentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 08:19 PDT by Ilya Tikhonovsky
Modified: 2012-07-13 02:02 PDT (History)
16 users (show)

See Also:


Attachments
Patch (11.95 KB, patch)
2012-07-12 08:31 PDT, Ilya Tikhonovsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-07-12 08:19:04 PDT
EOM
Comment 1 Ilya Tikhonovsky 2012-07-12 08:31:23 PDT
Created attachment 151964 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-07-12 09:00:06 PDT
Committed r122466: <http://trac.webkit.org/changeset/122466>
Comment 3 Yury Semikhatsky 2012-07-12 20:58:10 PDT
Comment on attachment 151964 [details]
Patch

Could you explain which what kind of problem this patch addresses?
Comment 4 Ilya Tikhonovsky 2012-07-13 02:02:39 PDT
(In reply to comment #3)
> (From update of attachment 151964 [details])
> Could you explain which what kind of problem this patch addresses?

bindings related classes were instrumented a little bit different way than other WebCore code. I just made the instrumentation a bit more consistent. In next patches I'd like to slightly adjust the instrumentation API. It'd be simpler to do that if the instrumentation code uses a single pattern.