WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
91087
Web Inspector: beautify find bar looks, simplify search update routines.
https://bugs.webkit.org/show_bug.cgi?id=91087
Summary
Web Inspector: beautify find bar looks, simplify search update routines.
Pavel Feldman
Reported
2012-07-12 06:20:22 PDT
This change updates the looks to the one on the screenshots and simplifies match count update routines.
Attachments
[IMAGE] Screenshot with patch applied.
(11.07 KB, image/png)
2012-07-12 06:21 PDT
,
Pavel Feldman
no flags
Details
Patch
(16.71 KB, patch)
2012-07-12 06:24 PDT
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Patch
(18.56 KB, patch)
2012-07-12 07:05 PDT
,
Pavel Feldman
vsevik
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-07-12 06:21:04 PDT
Created
attachment 151935
[details]
[IMAGE] Screenshot with patch applied.
Pavel Feldman
Comment 2
2012-07-12 06:24:30 PDT
Created
attachment 151937
[details]
Patch
Andrey Kosyakov
Comment 3
2012-07-12 06:43:29 PDT
Comment on
attachment 151937
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=151937&action=review
> Source/WebCore/inspector/front-end/SearchController.js:41 > + labelElement.textContent = "Find";
UIString?
Vsevolod Vlasov
Comment 4
2012-07-12 06:50:10 PDT
Comment on
attachment 151937
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=151937&action=review
> Source/WebCore/inspector/front-end/SearchController.js:-249 > - if (!isEnterKey(event))
Incremental search works weirdly now - it jumps to the next occurrence each time you add a letter even if current occurrence matches new query. I believe this code was needed.
Pavel Feldman
Comment 5
2012-07-12 07:05:28 PDT
Created
attachment 151943
[details]
Patch
Vsevolod Vlasov
Comment 6
2012-07-12 08:02:12 PDT
Comment on
attachment 151943
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=151943&action=review
> Source/WebCore/inspector/front-end/SearchController.js:240 > + _performSearch: function(query, forceSearch, isBackwardSearch)
Please annotate all parameters.
Pavel Feldman
Comment 7
2012-07-12 08:54:38 PDT
Committed
r122465
: <
http://trac.webkit.org/changeset/122465
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug